class RuboCop::Cop::Rails::Delegate
This cop looks for delegations, that could have been created automatically with delegate method.
@example
# bad def bar foo.bar end # good delegate :bar, to: :foo # bad def foo_bar foo.bar end # good delegate :bar, to: :foo, prefix: true # good private def bar foo.bar end
Constants
- MSG
Public Instance Methods
on_def(node)
click to toggle source
# File lib/rubocop/cop/rails/delegate.rb, line 34 def on_def(node) method_name, args, body = *node return unless trivial_delegate?(method_name, args, body) return if private_or_protected_delegation(node) add_offense(node, :keyword, MSG) end
Private Instance Methods
arguments_match?(args, body)
click to toggle source
# File lib/rubocop/cop/rails/delegate.rb, line 69 def arguments_match?(args, body) _receiver, _method_name, *arguments = *body arg_array = Array(args) argument_array = Array(arguments) arg_array.size == argument_array.size && ( arg_array == argument_array || arg_array.map(&:children) == argument_array.map(&:children) ) end
autocorrect(node)
click to toggle source
# File lib/rubocop/cop/rails/delegate.rb, line 43 def autocorrect(node) method_name, _args, body = *node delegation = ["delegate :#{body.children[1]}", "to: :#{body.children[0].children[1]}"] if method_name == prefixed_method_name(body) delegation << ['prefix: true'] end lambda do |corrector| corrector.replace(node.source_range, delegation.join(', ')) end end
delegate?(body)
click to toggle source
# File lib/rubocop/cop/rails/delegate.rb, line 62 def delegate?(body) receiver, * = *body return false unless receiver.is_a? Parser::AST::Node return false unless receiver.type == :send receiver.child_nodes.empty? end
method_name_matches?(method_name, body)
click to toggle source
# File lib/rubocop/cop/rails/delegate.rb, line 79 def method_name_matches?(method_name, body) _receiver, property_name, *_args = *body method_name == property_name || method_name == prefixed_method_name(body) end
prefixed_method_name(body)
click to toggle source
# File lib/rubocop/cop/rails/delegate.rb, line 85 def prefixed_method_name(body) receiver, property_name, *_args = *body _receiver, target, *_args = *receiver [target, property_name].join('_').to_sym end
private_or_protected_before(line)
click to toggle source
# File lib/rubocop/cop/rails/delegate.rb, line 97 def private_or_protected_before(line) (processed_source[0..line].map(&:strip) & %w(private protected)).any? end
private_or_protected_delegation(node)
click to toggle source
# File lib/rubocop/cop/rails/delegate.rb, line 91 def private_or_protected_delegation(node) line = node.loc.line private_or_protected_before(line) || private_or_protected_inline(line) end
private_or_protected_inline(line)
click to toggle source
# File lib/rubocop/cop/rails/delegate.rb, line 101 def private_or_protected_inline(line) processed_source[line - 1].strip =~ /\A(private )|(protected )/ end
trivial_delegate?(method_name, args, body)
click to toggle source
# File lib/rubocop/cop/rails/delegate.rb, line 56 def trivial_delegate?(method_name, args, body) body && delegate?(body) && method_name_matches?(method_name, body) && arguments_match?(args, body) end