From nobody@FreeBSD.org Sat Nov 19 07:39:49 2005 Return-Path: Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id F0F3C16A41F for ; Sat, 19 Nov 2005 07:39:49 +0000 (GMT) (envelope-from nobody@FreeBSD.org) Received: from www.freebsd.org (www.freebsd.org [216.136.204.117]) by mx1.FreeBSD.org (Postfix) with ESMTP id C804143D45 for ; Sat, 19 Nov 2005 07:39:49 +0000 (GMT) (envelope-from nobody@FreeBSD.org) Received: from www.freebsd.org (localhost [127.0.0.1]) by www.freebsd.org (8.13.1/8.13.1) with ESMTP id jAJ7dn4M073084 for ; Sat, 19 Nov 2005 07:39:49 GMT (envelope-from nobody@www.freebsd.org) Received: (from nobody@localhost) by www.freebsd.org (8.13.1/8.13.1/Submit) id jAJ7dnJe073083; Sat, 19 Nov 2005 07:39:49 GMT (envelope-from nobody) Message-Id: <200511190739.jAJ7dnJe073083@www.freebsd.org> Date: Sat, 19 Nov 2005 07:39:49 GMT From: "Don L. Belcher" To: freebsd-gnats-submit@FreeBSD.org Subject: usb headset does not work with uaudio module X-Send-Pr-Version: www-2.3 >Number: 89269 >Category: usb >Synopsis: usb headset does not work with uaudio module >Confidential: no >Severity: non-critical >Priority: low >Responsible: freebsd-usb >State: closed >Quarter: >Keywords: >Date-Required: >Class: sw-bug >Submitter-Id: current-users >Arrival-Date: Sat Nov 19 07:40:31 GMT 2005 >Closed-Date: Thu Dec 29 18:11:34 GMT 2005 >Last-Modified: Thu Dec 29 18:11:34 GMT 2005 >Originator: Don L. Belcher >Release: FreeBSD 6 >Organization: SIAD, Inc. >Environment: FreeBSD rover.siad.net 6.0-RC1 FreeBSD 6.0-RC1 #9: Sat Oct 29 06:45:46 PDT 2005 don@rover.siad.net:/usr/obj/usr/home/don/FreeBSD-Version6/src/sys/GENERIC i386 >Description: if usb audio device is at the max or min sample rate an error is returned in this case the max sample rate is 48000 for device. The code checks for max sample < 48000 but should be <= 48000 to work. >How-To-Repeat: >Fix: change sample rate checks to <= src/sys/dev/sound/usb diff uaudio.c uaudio.c.orig 3754,3755c3754,3755 < if (UA_SAMP_LO(a1d) <= ch->sample_rate && < ch->sample_rate <= UA_SAMP_HI(a1d)) { --- > if (UA_SAMP_LO(a1d) < ch->sample_rate && > ch->sample_rate < UA_SAMP_HI(a1d)) { rov >Release-Note: >Audit-Trail: From: Alexander Leidinger To: "Don L. Belcher" Cc: freebsd-gnats-submit@freebsd.org, multimedia@freebsd.org Subject: Re: usb/89269: usb headset does not work with uaudio module Date: Sun, 20 Nov 2005 13:15:49 +0100 On Sat, 19 Nov 2005 07:39:49 GMT "Don L. Belcher" wrote: > if usb audio device is at the max or min sample rate an error is returned > in this case the max sample rate is 48000 for device. The code > checks for max sample < 48000 but should be <= 48000 to work. Can you please try -current instead of 6.0-RC1? We've changed some parts in uaudio. Bye, Alexander. -- Where do you think you're going today? http://www.Leidinger.net Alexander @ Leidinger.net GPG fingerprint = C518 BC70 E67F 143F BE91 3365 79E2 9C60 B006 3FE7 State-Changed-From-To: open->closed State-Changed-By: netchild State-Changed-When: Thu Dec 29 18:11:27 UTC 2005 State-Changed-Why: Committed. Thanks. http://www.freebsd.org/cgi/query-pr.cgi?pr=89269 >Unformatted: