From kibab@backbone.deglitch.com Sat Jul 25 19:42:19 2009 Return-Path: Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 956001065673 for ; Sat, 25 Jul 2009 19:42:19 +0000 (UTC) (envelope-from kibab@backbone.deglitch.com) Received: from mx0.deglitch.com (backbone.deglitch.com [IPv6:2001:16d8:fffb:4::abba]) by mx1.freebsd.org (Postfix) with ESMTP id 4E4408FC18 for ; Sat, 25 Jul 2009 19:42:19 +0000 (UTC) (envelope-from kibab@backbone.deglitch.com) Received: by mx0.deglitch.com (Postfix, from userid 2048) id 61AA08FC2B; Sat, 25 Jul 2009 23:42:17 +0400 (MSD) Message-Id: <20090725194217.61AA08FC2B@mx0.deglitch.com> Date: Sat, 25 Jul 2009 23:42:17 +0400 (MSD) From: Ilya Bakulin Reply-To: Ilya Bakulin To: FreeBSD-gnats-submit@freebsd.org Cc: Subject: QUIRK: ASUS PDA Flash disk emulation X-Send-Pr-Version: 3.113 X-GNATS-Notify: >Number: 137138 >Category: usb >Synopsis: [umass][usb67][patch] QUIRK: ASUS PDA Flash disk emulation >Confidential: no >Severity: non-critical >Priority: low >Responsible: gavin >State: closed >Quarter: >Keywords: >Date-Required: >Class: update >Submitter-Id: current-users >Arrival-Date: Sat Jul 25 19:50:01 UTC 2009 >Closed-Date: Mon Feb 08 12:56:22 UTC 2010 >Last-Modified: Mon Feb 08 12:56:22 UTC 2010 >Originator: Ilya Bakulin >Release: FreeBSD 8.0-BETA2 i386 >Organization: Deglitch Networks >Environment: System: FreeBSD kibab-nb.kibab.com 8.0-BETA2 FreeBSD 8.0-BETA2 #2: Sat Jul 25 19:47:18 MSD 2009 root@kibab-nb.kibab.com:/usr/obj/home/kibab/repos/fbsd-src-HEAD/src/src/sys/KIBAB-NB i386 >Description: ASUS PDAs have an exciting feature -- they can export plugged-in SD card filesystem as Mass Storage Device. One should just activate "Card Reader" option in PDA settings and connect it to PC. However, plugging in PDA results in errors due to failing Synchronize Cache operation. I've discovered that this problem disappears if "NO_SYNCHRONIZE_CACHE" quirk is applied during initial negotiation. >How-To-Repeat: Plug-in ASUS PDA with Card Reader options activated in USB configuration. Watch dmesg. You will see the following output: Jul 25 19:23:12 kibab-nb kernel: ugen3.3: at usbus3 Jul 25 19:23:12 kibab-nb kernel: umass0: on usbus3 Jul 25 19:23:12 kibab-nb kernel: umass0: SCSI over Bulk-Only; quirks = 0x0000 Jul 25 19:23:12 kibab-nb root: Unknown USB device: vendor 0x0b05 product 0x422f bus uhub0 Jul 25 19:23:13 kibab-nb kernel: umass0:2:0:-1: Attached to scbus2 Jul 25 19:23:13 kibab-nb kernel: da0 at umass-sim0 bus 0 target 0 lun 0 Jul 25 19:23:13 kibab-nb kernel: da0: < > Removable Direct Access SCSI-0 device Jul 25 19:23:13 kibab-nb kernel: da0: 1.000MB/s transfers Jul 25 19:23:13 kibab-nb kernel: da0: 1876MB (3842048 512 byte sectors: 255H 63S/T 239C) Jul 25 19:23:13 kibab-nb kernel: (da0:umass-sim0:0:0:0): Synchronize cache failed, status == 0x4, scsi status == 0x0 After applying attached patch to umass.c the problem disappears: Jul 25 20:04:14 kibab-nb kernel: ugen2.2: at usbus2 Jul 25 20:04:14 kibab-nb kernel: umass0: on usbus2 Jul 25 20:04:14 kibab-nb kernel: umass0: SCSI over Bulk-Only; quirks = 0x4000 Jul 25 20:04:14 kibab-nb root: Unknown USB device: vendor 0x0b05 product 0x422f bus uhub2 Jul 25 20:04:15 kibab-nb kernel: umass0:2:0:-1: Attached to scbus2 Jul 25 20:04:15 kibab-nb kernel: da0 at umass-sim0 bus 0 target 0 lun 0 Jul 25 20:04:15 kibab-nb kernel: da0: < > Removable Direct Access SCSI-0 device Jul 25 20:04:15 kibab-nb kernel: da0: 1.000MB/s transfers Jul 25 20:04:15 kibab-nb kernel: da0: 1876MB (3842048 512 byte sectors: 255H 63S/T 239C) >Fix: Apply attached patch, recompile kernel and reboot. --- umass.c.diff begins here --- --- sys/dev/usb/storage/umass.c 2009-07-25 19:41:20.000000000 +0400 +++ sys/dev/usb/storage/umass.c 2009-07-25 20:02:09.000000000 +0400 @@ -965,6 +965,11 @@ UMASS_PROTO_SCSI | UMASS_PROTO_BBB, NO_SYNCHRONIZE_CACHE }, + {USB_VENDOR_ASUS, 0x422f, RID_WILDCARD, + UMASS_PROTO_SCSI | UMASS_PROTO_BBB, + NO_SYNCHRONIZE_CACHE + }, + {VID_EOT, PID_EOT, RID_EOT, 0, 0} }; --- umass.c.diff ends here --- >Release-Note: >Audit-Trail: Responsible-Changed-From-To: freebsd-bugs->freebsd-usb Responsible-Changed-By: linimon Responsible-Changed-When: Sun Jul 26 00:40:32 UTC 2009 Responsible-Changed-Why: Over to maintainer(s). http://www.freebsd.org/cgi/query-pr.cgi?pr=137138 From: dfilter@FreeBSD.ORG (dfilter service) To: bug-followup@FreeBSD.org Cc: Subject: Re: usb/137138: commit references a PR Date: Mon, 24 Aug 2009 05:02:46 +0000 (UTC) Author: alfred Date: Mon Aug 24 05:02:36 2009 New Revision: 196495 URL: http://svn.freebsd.org/changeset/base/196495 Log: Add mass storage quirks. PR: usb/137138,usb/137226,usb/137789,usb/135372 Submitted by: hps Modified: head/sys/dev/usb/storage/umass.c head/sys/dev/usb/usbdevs Modified: head/sys/dev/usb/storage/umass.c ============================================================================== --- head/sys/dev/usb/storage/umass.c Mon Aug 24 05:01:40 2009 (r196494) +++ head/sys/dev/usb/storage/umass.c Mon Aug 24 05:02:36 2009 (r196495) @@ -412,6 +412,10 @@ static const struct umass_devdescr umass UMASS_PROTO_DEFAULT, NO_SYNCHRONIZE_CACHE }, + {USB_VENDOR_ALCOR, USB_PRODUCT_ALCOR_SDCR_6335, RID_WILDCARD, + UMASS_PROTO_DEFAULT, + NO_TEST_UNIT_READY | NO_SYNCHRONIZE_CACHE + }, {USB_VENDOR_ALCOR, USB_PRODUCT_ALCOR_AU6390, RID_WILDCARD, UMASS_PROTO_DEFAULT, NO_SYNCHRONIZE_CACHE @@ -733,6 +737,10 @@ static const struct umass_devdescr umass UMASS_PROTO_UFI, NO_QUIRKS }, + { USB_VENDOR_PHILIPS, USB_PRODUCT_PHILIPS_SPE3030CC, RID_WILDCARD, + UMASS_PROTO_DEFAULT, + NO_SYNCHRONIZE_CACHE + }, {USB_VENDOR_PLEXTOR, USB_PRODUCT_PLEXTOR_40_12_40U, RID_WILDCARD, UMASS_PROTO_SCSI | UMASS_PROTO_BBB, NO_TEST_UNIT_READY @@ -893,6 +901,10 @@ static const struct umass_devdescr umass UMASS_PROTO_UFI | UMASS_PROTO_CBI, NO_QUIRKS }, + {USB_VENDOR_TECLAST, USB_PRODUCT_TECLAST_TLC300, RID_WILDCARD, + UMASS_PROTO_DEFAULT, + NO_TEST_UNIT_READY | NO_SYNCHRONIZE_CACHE + }, {USB_VENDOR_TREK, USB_PRODUCT_TREK_MEMKEY, RID_WILDCARD, UMASS_PROTO_SCSI | UMASS_PROTO_BBB, NO_INQUIRY @@ -965,6 +977,10 @@ static const struct umass_devdescr umass UMASS_PROTO_SCSI | UMASS_PROTO_BBB, NO_SYNCHRONIZE_CACHE }, + {USB_VENDOR_ASUS, USB_PRODUCT_ASUS_GMSC, RID_WILDCARD, + UMASS_PROTO_DEFAULT, + NO_SYNCHRONIZE_CACHE + }, {VID_EOT, PID_EOT, RID_EOT, 0, 0} }; Modified: head/sys/dev/usb/usbdevs ============================================================================== --- head/sys/dev/usb/usbdevs Mon Aug 24 05:01:40 2009 (r196494) +++ head/sys/dev/usb/usbdevs Mon Aug 24 05:02:36 2009 (r196495) @@ -360,6 +360,7 @@ vendor SMC 0x0707 Standard Microsystems vendor PUTERCOM 0x0708 Putercom vendor MCT 0x0711 MCT vendor IMATION 0x0718 Imation +vendor TECLAST 0x071b Teclast vendor SONYERICSSON 0x0731 Sony Ericsson vendor EICON 0x0734 Eicon Networks vendor SYNTECH 0x0745 Syntech Information @@ -585,6 +586,7 @@ vendor NETGEAR3 0x1385 Netgear vendor BALTECH 0x13ad Baltech vendor CISCOLINKSYS 0x13b1 Cisco-Linksys vendor SHARK 0x13d2 Shark +vendor EMTEC 0x13fe Emtec vendor NOVATEL 0x1410 Novatel Wireless vendor MERLIN 0x1416 Merlin vendor WISTRONNEWEB 0x1435 Wistron NeWeb @@ -820,6 +822,7 @@ product AKS USBHASP 0x0001 USB-HASP 0.0 /* Alcor Micro, Inc. products */ product ALCOR2 KBD_HUB 0x2802 Kbd Hub +product ALCOR SDCR_6335 0x6335 SD/MMC Card Reader product ALCOR TRANSCEND 0x6387 Transcend JetFlash Drive product ALCOR MA_KBD_HUB 0x9213 MacAlly Kbd Hub product ALCOR AU9814 0x9215 AU9814 Hub @@ -861,6 +864,12 @@ product APC UPS 0x0002 Uninterruptible /* Apple Computer products */ product APPLE EXT_KBD 0x020c Apple Extended USB Keyboard +product APPLE KBD_TP_ANSI 0x0223 Apple Internal Keyboard/Trackpad (Wellspring/ANSI) +product APPLE KBD_TP_ISO 0x0224 Apple Internal Keyboard/Trackpad (Wellspring/ISO) +product APPLE KBD_TP_JIS 0x0225 Apple Internal Keyboard/Trackpad (Wellspring/JIS) +product APPLE KBD_TP_ANSI2 0x0230 Apple Internal Keyboard/Trackpad (Wellspring2/ANSI) +product APPLE KBD_TP_ISO2 0x0231 Apple Internal Keyboard/Trackpad (Wellspring2/ISO) +product APPLE KBD_TP_JIS2 0x0232 Apple Internal Keyboard/Trackpad (Wellspring2/JIS) product APPLE OPTMOUSE 0x0302 Optical mouse product APPLE MIGHTYMOUSE 0x0304 Mighty Mouse product APPLE EXT_KBD_HUB 0x1003 Hub in Apple Extended USB Keyboard @@ -902,6 +911,7 @@ product ASUS RT2573_1 0x1723 RT2573 product ASUS RT2573_2 0x1724 RT2573 product ASUS LCM 0x1726 LCM display product ASUS P535 0x420f ASUS P535 PDA +product ASUS GMSC 0x422f ASUS Generic Mass Storage /* ATen products */ product ATEN UC1284 0x2001 Parallel printer @@ -1971,6 +1981,7 @@ product PHILIPS HUB 0x0201 hub product PHILIPS PCA646VC 0x0303 PCA646VC PC Camera product PHILIPS PCVC680K 0x0308 PCVC680K Vesta Pro PC Camera product PHILIPS DSS150 0x0471 DSS 150 Digital Speaker System +product PHILIPS SPE3030CC 0x083a USB 2.0 External Disk product PHILIPS SNU5600 0x1236 SNU5600 product PHILIPS UM10016 0x1552 ISP 1581 Hi-Speed USB MPEG2 Encoder Reference Kit product PHILIPS DIVAUSB 0x1801 DIVA USB mp3 player @@ -2345,6 +2356,9 @@ product SUN KBD_HUB 0x100e Kbd Hub /* Super Top products */ product SUPERTOP IDE 0x6600 USB-IDE +/* Teclast products */ +product TECLAST TLC300 0x3203 USB Media Player + /* Supra products */ product DIAMOND2 SUPRAEXPRESS56K 0x07da Supra Express 56K modem product DIAMOND2 SUPRA2890 0x0b4a SupraMax 2890 56K Modem _______________________________________________ svn-src-all@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/svn-src-all To unsubscribe, send any mail to "svn-src-all-unsubscribe@freebsd.org" State-Changed-From-To: open->feedback State-Changed-By: gavin State-Changed-When: Fri Sep 11 09:47:58 UTC 2009 State-Changed-Why: To submitter: This has been fixed in HEAD so will be in 8.0 when it is released. Do you know if it is also an issue in 7.x? Thanks! Responsible-Changed-From-To: freebsd-usb->gavin Responsible-Changed-By: gavin Responsible-Changed-When: Fri Sep 11 09:47:58 UTC 2009 Responsible-Changed-Why: Track http://www.freebsd.org/cgi/query-pr.cgi?pr=137138 From: dfilter@FreeBSD.ORG (dfilter service) To: bug-followup@FreeBSD.org Cc: Subject: Re: usb/137138: commit references a PR Date: Thu, 29 Oct 2009 23:12:46 +0000 (UTC) Author: thompsa Date: Thu Oct 29 23:12:29 2009 New Revision: 198636 URL: http://svn.freebsd.org/changeset/base/198636 Log: MFC r196495 Add mass storage quirks. PR: usb/137138,usb/137226,usb/137789,usb/135372 Modified: stable/8/sys/ (props changed) stable/8/sys/amd64/include/xen/ (props changed) stable/8/sys/cddl/contrib/opensolaris/ (props changed) stable/8/sys/contrib/dev/acpica/ (props changed) stable/8/sys/contrib/pf/ (props changed) stable/8/sys/dev/usb/storage/umass.c stable/8/sys/dev/usb/usbdevs stable/8/sys/dev/xen/xenpci/ (props changed) Modified: stable/8/sys/dev/usb/storage/umass.c ============================================================================== --- stable/8/sys/dev/usb/storage/umass.c Thu Oct 29 23:11:48 2009 (r198635) +++ stable/8/sys/dev/usb/storage/umass.c Thu Oct 29 23:12:29 2009 (r198636) @@ -412,6 +412,10 @@ static const struct umass_devdescr umass UMASS_PROTO_DEFAULT, NO_SYNCHRONIZE_CACHE }, + {USB_VENDOR_ALCOR, USB_PRODUCT_ALCOR_SDCR_6335, RID_WILDCARD, + UMASS_PROTO_DEFAULT, + NO_TEST_UNIT_READY | NO_SYNCHRONIZE_CACHE + }, {USB_VENDOR_ALCOR, USB_PRODUCT_ALCOR_AU6390, RID_WILDCARD, UMASS_PROTO_DEFAULT, NO_SYNCHRONIZE_CACHE @@ -733,6 +737,10 @@ static const struct umass_devdescr umass UMASS_PROTO_UFI, NO_QUIRKS }, + { USB_VENDOR_PHILIPS, USB_PRODUCT_PHILIPS_SPE3030CC, RID_WILDCARD, + UMASS_PROTO_DEFAULT, + NO_SYNCHRONIZE_CACHE + }, {USB_VENDOR_PLEXTOR, USB_PRODUCT_PLEXTOR_40_12_40U, RID_WILDCARD, UMASS_PROTO_SCSI | UMASS_PROTO_BBB, NO_TEST_UNIT_READY @@ -893,6 +901,10 @@ static const struct umass_devdescr umass UMASS_PROTO_UFI | UMASS_PROTO_CBI, NO_QUIRKS }, + {USB_VENDOR_TECLAST, USB_PRODUCT_TECLAST_TLC300, RID_WILDCARD, + UMASS_PROTO_DEFAULT, + NO_TEST_UNIT_READY | NO_SYNCHRONIZE_CACHE + }, {USB_VENDOR_TREK, USB_PRODUCT_TREK_MEMKEY, RID_WILDCARD, UMASS_PROTO_SCSI | UMASS_PROTO_BBB, NO_INQUIRY @@ -965,6 +977,10 @@ static const struct umass_devdescr umass UMASS_PROTO_SCSI | UMASS_PROTO_BBB, NO_SYNCHRONIZE_CACHE }, + {USB_VENDOR_ASUS, USB_PRODUCT_ASUS_GMSC, RID_WILDCARD, + UMASS_PROTO_DEFAULT, + NO_SYNCHRONIZE_CACHE + }, {VID_EOT, PID_EOT, RID_EOT, 0, 0} }; Modified: stable/8/sys/dev/usb/usbdevs ============================================================================== --- stable/8/sys/dev/usb/usbdevs Thu Oct 29 23:11:48 2009 (r198635) +++ stable/8/sys/dev/usb/usbdevs Thu Oct 29 23:12:29 2009 (r198636) @@ -360,6 +360,7 @@ vendor SMC 0x0707 Standard Microsystems vendor PUTERCOM 0x0708 Putercom vendor MCT 0x0711 MCT vendor IMATION 0x0718 Imation +vendor TECLAST 0x071b Teclast vendor SONYERICSSON 0x0731 Sony Ericsson vendor EICON 0x0734 Eicon Networks vendor SYNTECH 0x0745 Syntech Information @@ -585,6 +586,7 @@ vendor NETGEAR3 0x1385 Netgear vendor BALTECH 0x13ad Baltech vendor CISCOLINKSYS 0x13b1 Cisco-Linksys vendor SHARK 0x13d2 Shark +vendor EMTEC 0x13fe Emtec vendor NOVATEL 0x1410 Novatel Wireless vendor MERLIN 0x1416 Merlin vendor WISTRONNEWEB 0x1435 Wistron NeWeb @@ -820,6 +822,7 @@ product AKS USBHASP 0x0001 USB-HASP 0.0 /* Alcor Micro, Inc. products */ product ALCOR2 KBD_HUB 0x2802 Kbd Hub +product ALCOR SDCR_6335 0x6335 SD/MMC Card Reader product ALCOR TRANSCEND 0x6387 Transcend JetFlash Drive product ALCOR MA_KBD_HUB 0x9213 MacAlly Kbd Hub product ALCOR AU9814 0x9215 AU9814 Hub @@ -861,6 +864,12 @@ product APC UPS 0x0002 Uninterruptible /* Apple Computer products */ product APPLE EXT_KBD 0x020c Apple Extended USB Keyboard +product APPLE KBD_TP_ANSI 0x0223 Apple Internal Keyboard/Trackpad (Wellspring/ANSI) +product APPLE KBD_TP_ISO 0x0224 Apple Internal Keyboard/Trackpad (Wellspring/ISO) +product APPLE KBD_TP_JIS 0x0225 Apple Internal Keyboard/Trackpad (Wellspring/JIS) +product APPLE KBD_TP_ANSI2 0x0230 Apple Internal Keyboard/Trackpad (Wellspring2/ANSI) +product APPLE KBD_TP_ISO2 0x0231 Apple Internal Keyboard/Trackpad (Wellspring2/ISO) +product APPLE KBD_TP_JIS2 0x0232 Apple Internal Keyboard/Trackpad (Wellspring2/JIS) product APPLE OPTMOUSE 0x0302 Optical mouse product APPLE MIGHTYMOUSE 0x0304 Mighty Mouse product APPLE EXT_KBD_HUB 0x1003 Hub in Apple Extended USB Keyboard @@ -902,6 +911,7 @@ product ASUS RT2573_1 0x1723 RT2573 product ASUS RT2573_2 0x1724 RT2573 product ASUS LCM 0x1726 LCM display product ASUS P535 0x420f ASUS P535 PDA +product ASUS GMSC 0x422f ASUS Generic Mass Storage /* ATen products */ product ATEN UC1284 0x2001 Parallel printer @@ -1971,6 +1981,7 @@ product PHILIPS HUB 0x0201 hub product PHILIPS PCA646VC 0x0303 PCA646VC PC Camera product PHILIPS PCVC680K 0x0308 PCVC680K Vesta Pro PC Camera product PHILIPS DSS150 0x0471 DSS 150 Digital Speaker System +product PHILIPS SPE3030CC 0x083a USB 2.0 External Disk product PHILIPS SNU5600 0x1236 SNU5600 product PHILIPS UM10016 0x1552 ISP 1581 Hi-Speed USB MPEG2 Encoder Reference Kit product PHILIPS DIVAUSB 0x1801 DIVA USB mp3 player @@ -2345,6 +2356,9 @@ product SUN KBD_HUB 0x100e Kbd Hub /* Super Top products */ product SUPERTOP IDE 0x6600 USB-IDE +/* Teclast products */ +product TECLAST TLC300 0x3203 USB Media Player + /* Supra products */ product DIAMOND2 SUPRAEXPRESS56K 0x07da Supra Express 56K modem product DIAMOND2 SUPRA2890 0x0b4a SupraMax 2890 56K Modem _______________________________________________ svn-src-all@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/svn-src-all To unsubscribe, send any mail to "svn-src-all-unsubscribe@freebsd.org" State-Changed-From-To: feedback->closed State-Changed-By: linimon State-Changed-When: Mon Feb 8 12:56:08 UTC 2010 State-Changed-Why: Already committed to 8. http://www.freebsd.org/cgi/query-pr.cgi?pr=137138 >Unformatted: