From uspoerlein@gmail.com Sun May 27 15:33:20 2007 Return-Path: Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id A724416A47F for ; Sun, 27 May 2007 15:33:20 +0000 (UTC) (envelope-from uspoerlein@gmail.com) Received: from ug-out-1314.google.com (ug-out-1314.google.com [66.249.92.168]) by mx1.freebsd.org (Postfix) with ESMTP id 1985113C465 for ; Sun, 27 May 2007 15:33:19 +0000 (UTC) (envelope-from uspoerlein@gmail.com) Received: by ug-out-1314.google.com with SMTP id u2so691864uge for ; Sun, 27 May 2007 08:33:19 -0700 (PDT) Received: by 10.67.115.7 with SMTP id s7mr4563609ugm.1180279999159; Sun, 27 May 2007 08:33:19 -0700 (PDT) Received: from coyote.q.local ( [85.180.181.200]) by mx.google.com with ESMTP id a1sm4081087ugf.2007.05.27.08.33.17; Sun, 27 May 2007 08:33:18 -0700 (PDT) Received: from coyote.q.local (localhost [127.0.0.1]) by coyote.q.local (8.14.1/8.13.8) with ESMTP id l4RFXF2L002562; Sun, 27 May 2007 17:33:15 +0200 (CEST) (envelope-from q@coyote.q.local) Received: (from q@localhost) by coyote.q.local (8.14.1/8.13.8/Submit) id l4RFXF4e002561; Sun, 27 May 2007 17:33:15 +0200 (CEST) (envelope-from q) Message-Id: <200705271533.l4RFXF4e002561@coyote.q.local> Date: Sun, 27 May 2007 17:33:15 +0200 (CEST) From: Ulrich Spoerlein To: FreeBSD-gnats-submit@freebsd.org Cc: Hans Petter Selasky Subject: Samsung printer not working in bidirectional mode X-Send-Pr-Version: 3.113 X-GNATS-Notify: >Number: 113060 >Category: usb >Synopsis: [usb67] [ulpt] [patch] Samsung printer not working in bidirectional mode >Confidential: no >Severity: non-critical >Priority: low >Responsible: freebsd-usb >State: suspended >Quarter: >Keywords: >Date-Required: >Class: sw-bug >Submitter-Id: current-users >Arrival-Date: Sun May 27 15:40:04 GMT 2007 >Closed-Date: >Last-Modified: Fri Nov 12 20:48:10 UTC 2010 >Originator: Ulrich Spoerlein >Release: FreeBSD 6.2-STABLE i386 >Organization: >Environment: >Description: The following printer, when attached via USB fails to work port 2 addr 2: full speed, self powered, config 1, SAMSUNG Laser Printer ML-4600(0x3004), SAMSUNG ELECTRONICS CO., LT(0x04e8), rev 1.00 Peter van Heusden identified the problem to be the bi-directional mode. When adding the quirks as given below *OR* chmod a-w /dev/ulpt0 CUPS will print just fine. Please note that under the new USB stack developed by Hans Petter Selasky the printer works out of the box. This, and usb/112944 leave me to believe it is a more general problem with bidirectional support under ulpt(4). Perhaps HPS can comment on the architectural differences between the old and his new ulpt(4)? PS: Whitespace and sorting in usb_quirks.c are, well, interessting. >How-To-Repeat: >Fix: --- ml4600.diff begins here --- Index: usb_quirks.c =================================================================== RCS file: /home/ncvs/src/sys/dev/usb/usb_quirks.c,v retrieving revision 1.41.2.8 diff -u -p -r1.41.2.8 usb_quirks.c --- usb_quirks.c 28 Apr 2007 20:31:30 -0000 1.41.2.8 +++ usb_quirks.c 27 May 2007 15:31:37 -0000 @@ -99,6 +99,7 @@ Static const struct usbd_quirk_entry { { USB_VENDOR_HP, USB_PRODUCT_HP_810C, ANY, { UQ_BROKEN_BIDIR }}, { USB_VENDOR_HP, USB_PRODUCT_HP_830C, ANY, { UQ_BROKEN_BIDIR }}, { USB_VENDOR_HP, USB_PRODUCT_HP_1220C, ANY, { UQ_BROKEN_BIDIR }}, + { USB_VENDOR_SAMSUNG, USB_PRODUCT_SAMSUNG_ML4600, ANY, { UQ_BROKEN_BIDIR }}, { USB_VENDOR_XEROX, USB_PRODUCT_XEROX_WCM15, ANY, { UQ_BROKEN_BIDIR }}, /* YAMAHA router's ucdDevice is the version of farmware and often changes. */ { USB_VENDOR_YAMAHA, USB_PRODUCT_YAMAHA_RTA54I, Index: usbdevs =================================================================== RCS file: /home/ncvs/src/sys/dev/usb/usbdevs,v retrieving revision 1.232.2.24 diff -u -p -r1.232.2.24 usbdevs --- usbdevs 20 May 2007 12:34:39 -0000 1.232.2.24 +++ usbdevs 27 May 2007 09:30:30 -0000 @@ -1491,6 +1491,7 @@ product RATOC REXUSB60 0xb000 REX-USB60 product SAGEM USBSERIAL 0x0027 USB-Serial Controller /* Samsung products */ +product SAMSUNG ML4600 0x3004 ML-4600 laser printer product SAMSUNG ML6060 0x3008 ML-6060 laser printer /* SanDisk products */ --- ml4600.diff ends here --- >Release-Note: >Audit-Trail: From: Hans Petter Selasky To: freebsd-usb@freebsd.org Cc: Ulrich Spoerlein , FreeBSD-gnats-submit@freebsd.org Subject: Re: usb/113060: Samsung printer not working in bidirectional mode Date: Sun, 27 May 2007 22:32:32 +0200 Hi, The main difference between the old "ulpt" and the new "ulpt" is that the n= ew=20 use asynchronous reading of data, while the old "ulpt" uses synchronous=20 reading. That means that the new "ulpt" transfers data to/from all endpoint= s=20 in the background. Maybe that has something to do with the problem, that the IN enpoint is not= =20 polled. =2D-HPS State-Changed-From-To: open->analyzed State-Changed-By: linimon State-Changed-When: Fri Oct 17 15:21:41 UTC 2008 State-Changed-Why: hps@ confirms that this is ready for commit. http://www.freebsd.org/cgi/query-pr.cgi?pr=113060 State-Changed-From-To: analyzed->feedback State-Changed-By: gavin State-Changed-When: Mon Aug 31 11:54:31 UTC 2009 State-Changed-Why: To submitter: This is believed to actually be a bug in the ulpt(4) driver, and is believed to be fixed in the new USB stack in 8.x. Is there any chance you could test the patch from PR usb/103046 and see if that fixes things for you on 6.x or 7.x? Responsible-Changed-From-To: freebsd-usb->gavin Responsible-Changed-By: gavin Responsible-Changed-When: Mon Aug 31 11:54:31 UTC 2009 Responsible-Changed-Why: Track http://www.freebsd.org/cgi/query-pr.cgi?pr=113060 From: Ulrich =?utf-8?B?U3DDtnJsZWlu?= To: gavin@FreeBSD.org Cc: freebsd-usb@FreeBSD.org, bug-followup@FreeBSD.org Subject: Re: usb/113060: [usb67] [ulpt] [patch] Samsung printer not working in bidirectional mode Date: Mon, 31 Aug 2009 15:41:36 +0200 On Mon, 31.08.2009 at 11:55:53 +0000, gavin@FreeBSD.org wrote: > To submitter: This is believed to actually be a bug in the ulpt(4) > driver, and is believed to be fixed in the new USB stack in 8.x. > Is there any chance you could test the patch from PR usb/103046 > and see if that fixes things for you on 6.x or 7.x? Sorry, but I no longer own an USB printer :/ To that effect I cannot even test this on 8.x State-Changed-From-To: feedback->open State-Changed-By: gavin State-Changed-When: Fri Sep 18 13:48:30 UTC 2009 State-Changed-Why: Feedback was provided, submitter is unable to test Responsible-Changed-From-To: gavin->freebsd-usb Responsible-Changed-By: gavin Responsible-Changed-When: Fri Sep 18 13:48:30 UTC 2009 Responsible-Changed-Why: Over to maintainer(s) http://www.freebsd.org/cgi/query-pr.cgi?pr=113060 State-Changed-From-To: open->closed State-Changed-By: arundel State-Changed-When: Mon Sep 13 13:50:11 UTC 2010 State-Changed-Why: This issue is limited to the old usb stack. Since the submitter doesn't own the device any longer and thus chances of fixing this issue in stable/7 are very slim, close this PR. http://www.freebsd.org/cgi/query-pr.cgi?pr=113060 State-Changed-From-To: closed->suspended State-Changed-By: arundel State-Changed-When: Mon Sep 13 18:45:10 UTC 2010 State-Changed-Why: Rather suspend this PR than close it. Once 103046 gets fixed this PR should be fixed, too. http://www.freebsd.org/cgi/query-pr.cgi?pr=113060 >Unformatted: