From dan@obluda.cz Sat May 8 13:59:35 1999 Return-Path: Received: from dan-h.fio.cz (fio.vol.cz [195.250.146.50]) by hub.freebsd.org (Postfix) with ESMTP id 9BE22151B2 for ; Sat, 8 May 1999 13:59:15 -0700 (PDT) (envelope-from dan@obluda.cz) Received: (from dan@localhost) by dan-h.fio.cz (8.9.2/8.9.0) id WAA14713; Sat, 8 May 1999 22:58:31 +0200 (CEST) Received: (from dan@localhost) by dan-h.fio.cz (8.9.2/8.9.0) id SAA10538; Sat, 8 May 1999 18:36:26 +0200 (CEST) Message-Id: <199905081636.SAA10538@dan-h.fio.cz> Date: Sat, 8 May 1999 18:36:26 +0200 (CEST) From: dan@obluda.cz Reply-To: dan@obluda.cz To: FreeBSD-gnats-submit@freebsd.org Subject: bug in sources of package tac_plus-2.1 X-Send-Pr-Version: 3.2 >Number: 11593 >Category: ports >Synopsis: minor bug when config file not found in tacacsd >Confidential: no >Severity: non-critical >Priority: low >Responsible: freebsd-ports >State: closed >Quarter: >Keywords: >Date-Required: >Class: sw-bug >Submitter-Id: current-users >Arrival-Date: Sat May 8 14:00:04 PDT 1999 >Closed-Date: Sun May 9 09:50:35 PDT 1999 >Last-Modified: Sun May 9 09:52:00 PDT 1999 >Originator: Dan Lukes >Release: FreeBSD 3.1-RELEASE i386 >Organization: Obludarium >Environment: no specific environment package "tac_plus-2.1 installed" >Description: Segmentation fault when configuration file not found. See the code in the "fix" section: if (cf...==NULL) { ... fclose(cf) ... } The segmentation fault is caused by fclose(NULL) ... >How-To-Repeat: Start tacacsd with nonexistent configuration file. >Fix: The original publisher, Cisco systems, no longer offer and maintain tacacs sources, so we should patch existing sources rather than ask original publisher to correct it's sources ... Apply this patch to source from the package is compiled from: *** config.c.ORIG Fri May 7 22:49:55 1999 --- config.c Fri May 7 23:24:33 1999 *************** *** 1212,1218 **** if ((cf = fopen(cfile, "r")) == NULL) { report(LOG_ERR, "read_config: fopen() error for file %s %s, exiting", cfile, sys_errlist[errno]); - fclose(cf); return (1); } if (parse_decls() || sym_error) { >Release-Note: >Audit-Trail: State-Changed-From-To: open->closed State-Changed-By: steve State-Changed-When: Sun May 9 09:50:35 PDT 1999 State-Changed-Why: Committed, thanks! >Unformatted: