From bz@zabbadoz.net Mon Jul 4 13:59:02 2005 Return-Path: Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 1227816A41C for ; Mon, 4 Jul 2005 13:59:02 +0000 (GMT) (envelope-from bz@zabbadoz.net) Received: from transport.cksoft.de (transport.cksoft.de [62.111.66.27]) by mx1.FreeBSD.org (Postfix) with ESMTP id C8C2D43D49 for ; Mon, 4 Jul 2005 13:59:01 +0000 (GMT) (envelope-from bz@zabbadoz.net) Received: from transport.cksoft.de (localhost [127.0.0.1]) by transport.cksoft.de (Postfix) with ESMTP id CBA6B1FFACB for ; Mon, 4 Jul 2005 15:58:58 +0200 (CEST) Received: by transport.cksoft.de (Postfix, from userid 66) id 7EDCB1FF9AF; Mon, 4 Jul 2005 15:58:56 +0200 (CEST) Received: by mail.int.zabbadoz.net (Postfix, from userid 1060) id 06FC8157B9; Mon, 4 Jul 2005 13:58:43 +0000 (UTC) Message-Id: <20050704135843.06FC8157B9@mail.int.zabbadoz.net> Date: Mon, 4 Jul 2005 13:58:43 +0000 (UTC) From: "Bjoern A. Zeeb" Reply-To: "Bjoern A. Zeeb" To: FreeBSD-gnats-submit@freebsd.org Cc: "Bjoern A. Zeeb" Subject: RTM_CHANGE incorrectly changes default X-Send-Pr-Version: 3.113 X-GNATS-Notify: >Number: 82974 >Category: kern >Synopsis: RTM_CHANGE incorrectly changes default >Confidential: no >Severity: serious >Priority: medium >Responsible: gnn@freebsd.org >State: closed >Quarter: >Keywords: >Date-Required: >Class: sw-bug >Submitter-Id: current-users >Arrival-Date: Mon Jul 04 14:00:18 GMT 2005 >Closed-Date: Fri Jul 15 09:24:14 GMT 2005 >Last-Modified: Mon Apr 9 19:50:07 GMT 2007 >Originator: Bjoern A. Zeeb >Release: FreeBSD 6.0-CURRENT amd64 >Organization: Zabbadoz.NeT >Environment: >Description: route change of a nonexistent host route changes default route instead of returning error. route monitor returns change given but not change done. I had seen this this problem on a 5.4-PRERELEASE machine from about Mar 31 and verified that it still exists in HEAD. >How-To-Repeat: foo# netstat -rn -f inet | grep default default 192.168.64.1 UGS 0 27 em0 foo# netstat -rn -f inet | grep 10.1 foo# route change 10.1.2.3 127.0.0.1 change host 10.1.2.3: gateway 127.0.0.1 got message of size 124 on Mon Jul 4 13:42:55 2005 RTM_CHANGE: Change Metrics or flags: len 124, pid: 55414, seq 1, errno 0, flags: locks: inits: sockaddrs: 10.1.2.3 127.0.0.1 foo# netstat -rn -f inet | grep 10.1 foo# netstat -rn -f inet | grep default default 127.0.0.1 UGS 0 27 lo0 >Fix: 1.124 +19 -0 src/sys/net/rtsock.c >Release-Note: >Audit-Trail: State-Changed-From-To: open->closed State-Changed-By: gnn State-Changed-When: Fri Jul 15 08:57:52 GMT 2005 State-Changed-Why: Bug fixed by related commit. Responsible-Changed-From-To: freebsd-bugs->gnn@freebsd.org Responsible-Changed-By: gnn Responsible-Changed-When: Fri Jul 15 08:57:52 GMT 2005 Responsible-Changed-Why: Bug fixed by related commit. http://www.freebsd.org/cgi/query-pr.cgi?pr=82974 From: dfilter@FreeBSD.ORG (dfilter service) To: bug-followup@FreeBSD.org Cc: Subject: Re: kern/82974: commit references a PR Date: Mon, 9 Apr 2007 19:44:25 +0000 (UTC) emaste 2007-04-09 19:44:19 UTC FreeBSD src repository Modified files: (Branch: RELENG_6) sys/net rtsock.c Log: MFC rtsock.c r1.124, which was overlooked some time ago: Fix for PR 82974. We were not checking that the route looked up in the case of an RTM_CHANGE was specific, i.e. that it matched completely. This led to a route change of a non-existent route changing the default route as the radix code would simply back track to that point and hand that route back to the routing socket code. PR: 82974 Reviewed by: Tai-hwa Liang Ben Kaduk Bjoern A. Zeeb Obtained from: OpenBSD with modifications. Revision Changes Path 1.123.2.8 +19 -0 src/sys/net/rtsock.c _______________________________________________ cvs-all@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/cvs-all To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org" >Unformatted: