From keramida@ceid.upatras.gr Wed Jun 20 11:07:51 2001 Return-Path: Received: from mailsrv.otenet.gr (mailsrv.otenet.gr [195.170.0.5]) by hub.freebsd.org (Postfix) with ESMTP id 94E1537B401 for ; Wed, 20 Jun 2001 11:07:50 -0700 (PDT) (envelope-from keramida@ceid.upatras.gr) Received: from hades.hell.gr (patr530-b104.otenet.gr [195.167.121.232]) by mailsrv.otenet.gr (8.11.1/8.11.1) with ESMTP id f5KI7lS00957 for ; Wed, 20 Jun 2001 21:07:47 +0300 (EEST) Received: (from charon@localhost) by hades.hell.gr (8.11.4/8.11.3) id f5KHUQw00719; Wed, 20 Jun 2001 20:30:26 +0300 (EEST) (envelope-from charon) Message-Id: <200106201730.f5KHUQw00719@hades.hell.gr> Date: Wed, 20 Jun 2001 20:30:26 +0300 (EEST) From: Giorgos Keramidas Reply-To: Giorgos Keramidas To: FreeBSD-gnats-submit@freebsd.org Cc: Subject: change request for sys/i386/conf/NOTES X-Send-Pr-Version: 3.113 X-GNATS-Notify: >Number: 28297 >Category: kern >Synopsis: change request for sys/i386/conf/NOTES >Confidential: no >Severity: non-critical >Priority: low >Responsible: freebsd-bugs >State: closed >Quarter: >Keywords: >Date-Required: >Class: change-request >Submitter-Id: current-users >Arrival-Date: Wed Jun 20 11:10:06 PDT 2001 >Closed-Date: Sun May 16 13:20:01 PDT 2004 >Last-Modified: Sun May 16 13:20:01 PDT 2004 >Originator: Giorgos Keramidas >Release: FreeBSD 5.0-CURRENT i386 >Organization: >Environment: System: FreeBSD hades.hell.gr 5.0-CURRENT FreeBSD 5.0-CURRENT #0: Wed Jun 20 12:35:01 EEST 2001 root@hades.hell.gr:/usr/obj/usr/src/sys/GENERIC i386 >Description: The NOTES file of 5.0-CURRENT (CVSup'ed yesterday, Tue Jun 19 2001), says the following in the description of NTIMECOUNTER # The default is 5, there is no upper limit but more than a couple # of hundred are not productive. But the value of NTIMECOUNTER in NOTES a few lines below is 20. options NTIMECOUNTER=20 >How-To-Repeat: Well, look at the source of NOTES revision 1.926. >Fix: Change either the description to match the default, or the default to match the description. >Release-Note: >Audit-Trail: From: Dima Dorfman To: Giorgos Keramidas Cc: FreeBSD-gnats-submit@freebsd.org Subject: Re: kern/28297: change request for sys/i386/conf/NOTES Date: Wed, 20 Jun 2001 14:52:25 -0700 Giorgos Keramidas writes: > > >Number: 28297 > >Category: kern > >Synopsis: change request for sys/i386/conf/NOTES > >Description: > > The NOTES file of 5.0-CURRENT (CVSup'ed yesterday, Tue Jun 19 2001), > says the following in the description of NTIMECOUNTER > > # The default is 5, there is no upper limit but more than a couple > # of hundred are not productive. > > But the value of NTIMECOUNTER in NOTES a few lines below is 20. > > options NTIMECOUNTER=20 > > >Fix: > > Change either the description to match the default, > or the default to match the description. NOTES isn't supposed to set the variables to their defaults. NOTES is supposed to set variables to values *other* than the default to potentially catch places where the default is hardcoded in (which shouldn't be). > > >Release-Note: > >Audit-Trail: > >Unformatted: > > To Unsubscribe: send mail to majordomo@FreeBSD.org > with "unsubscribe freebsd-bugs" in the body of the message > From: Bruce Evans To: Giorgos Keramidas Cc: Dima Dorfman , freebsd-gnats-submit@FreeBSD.ORG, phk@FreeBSD.ORG Subject: Re: kern/28297: change request for sys/i386/conf/NOTES Date: Thu, 21 Jun 2001 15:58:17 +1000 (EST) On Thu, 21 Jun 2001, Giorgos Keramidas wrote: > On Wed, Jun 20, 2001 at 03:20:03PM -0700, Dima Dorfman wrote: > > NOTES isn't supposed to set the variables to their defaults. NOTES is > > supposed to set variables to values *other* than the default to > > potentially catch places where the default is hardcoded in (which > > shouldn't be). > > Yes, if NOTES is not supposed to set variables to their defaults, this > seems reasonable. Am sure we can close this PR in that case. The > comment seemed to indicate that this is the default though. Perhaps > we should reword the comment to read something like: > > The default is 5, although you can set it to any other value (for > instance 20) as shown below. Except the default isn't 5 in -current; it used to be 5; but was changed to 45 in rev.1.109 of kern_tc.c (the SMPng megacommit). The log message for rev.1.09 of course didn't say anything about this change. It should have said something like "work around problems caused by extra interrupt latency in SMPng by incrementing NTIMECOUNTER to 45"). There are many nearby bugs. E.g, "sysctl -w kern.timecounter.method=1" isn't a good strategy, and it doesn't exist in -current. Bruce From: Giorgos Keramidas To: Bruce Evans Cc: Dima Dorfman , freebsd-gnats-submit@FreeBSD.ORG, phk@FreeBSD.ORG Subject: Re: kern/28297: change request for sys/i386/conf/NOTES Date: Thu, 21 Jun 2001 19:18:10 +0300 On Thu, Jun 21, 2001 at 03:58:17PM +1000, Bruce Evans wrote: > On Thu, 21 Jun 2001, Giorgos Keramidas wrote: > > > > Yes, if NOTES is not supposed to set variables to their defaults, this > > seems reasonable. Am sure we can close this PR in that case. The > > comment seemed to indicate that this is the default though. Perhaps > > we should reword the comment to read something like: > > > > The default is 5, although you can set it to any other value (for > > instance 20) as shown below. > > Except the default isn't 5 in -current; it used to be 5; but was changed > to 45 in rev.1.109 of kern_tc.c (the SMPng megacommit). The log message > for rev.1.09 of course didn't say anything about this change. It > should have said something like "work around problems caused by extra > interrupt latency in SMPng by incrementing NTIMECOUNTER to 45"). > > There are many nearby bugs. E.g, "sysctl -w kern.timecounter.method=1" > isn't a good strategy, and it doesn't exist in -current. Ahem. I just checked with `sysctl -a | grep timecounter' and you are right, as I expected. Well, if you ask me, NOTES needs to be updated a bit, but I'm afraid that I dont have all the knowledge it takes. All I can do is, when I come up with differences in what I see and whats described in there, to file a PR and say so. Well, any suggestions for the matter at hand? The NTIMECOUNTER description in NOTES, I mean. -giorgos State-Changed-From-To: open->closed State-Changed-By: josef State-Changed-When: Sun May 16 13:19:27 PDT 2004 State-Changed-Why: This option got removed. http://www.freebsd.org/cgi/query-pr.cgi?pr=28297 >Unformatted: