From brandt@fokus.gmd.de Wed Jun 6 05:01:37 2001 Return-Path: Received: from mailhub.fokus.gmd.de (mailhub.fokus.gmd.de [193.174.154.14]) by hub.freebsd.org (Postfix) with ESMTP id B025C37B403 for ; Wed, 6 Jun 2001 05:01:36 -0700 (PDT) (envelope-from brandt@fokus.gmd.de) Received: from fokus.gmd.de (beagle [193.175.132.100]) by mailhub.fokus.gmd.de (8.8.8/8.8.8) with ESMTP id OAA06529 for ; Wed, 6 Jun 2001 14:01:35 +0200 (MET DST) Received: (from root@localhost) by fokus.gmd.de (8.11.3/8.11.0) id f56C1Zx67238; Wed, 6 Jun 2001 14:01:35 +0200 (CEST) (envelope-from hbb) Message-Id: <200106061201.f56C1Zx67238@fokus.gmd.de> Date: Wed, 6 Jun 2001 14:01:35 +0200 (CEST) From: brandt@fokus.gmd.de Reply-To: brandt@fokus.gmd.de To: FreeBSD-gnats-submit@freebsd.org Subject: NG_SEND_MSG_HOOK fails to set the return address for the response X-Send-Pr-Version: 3.113 >Number: 27906 >Category: kern >Synopsis: NG_SEND_MSG_HOOK fails to set the return address for the response >Confidential: no >Severity: non-critical >Priority: medium >Responsible: julian >State: closed >Quarter: >Keywords: >Date-Required: >Class: sw-bug >Submitter-Id: current-users >Arrival-Date: Wed Jun 06 05:10:01 PDT 2001 >Closed-Date: Fri Jul 13 23:03:00 PDT 2001 >Last-Modified: Fri Jul 13 23:03:35 PDT 2001 >Originator: Harti Brandt >Release: FreeBSD 5.0-CURRENT i386 >Organization: GMD Fokus, Berlin, Germany >Environment: System: FreeBSD beagle.fokus.gmd.de 5.0-CURRENT FreeBSD 5.0-CURRENT #0: Wed Apr 4 11:23:55 CEST 2001 hbb@beagle.fokus.gmd.de:/opt/obj/usr/src/sys/BEAGLE i386 >Description: NG_SEND_MSG_HOOK, as defined in netgraph.h has a 5th parameter 'retaddr' which specifies the node ID of the node, which should receive a response to the message. This parameter is passed to ng_address_hook() which, at present, ignores it. This leads to the response beeing dropped by the netgraph base code. >How-To-Repeat: Create a netgraph node, which sends a message to another node via a hook by using NG_SEND_MSG_HOOK. Observe, that the response from the receiving node is lost. >Fix: Patch to ng_base.c: Index: ng_base.c =================================================================== RCS file: /usr/ncvs/src/sys/netgraph/ng_base.c,v retrieving revision 1.54 diff -r1.54 ng_base.c 3490a3491 > SET_RETADDR(item, here, retaddr); >Release-Note: >Audit-Trail: Responsible-Changed-From-To: freebsd-bugs->julian Responsible-Changed-By: alfred Responsible-Changed-When: Fri Jul 13 01:38:08 PDT 2001 Responsible-Changed-Why: Julian is Mr Netgraph. http://www.FreeBSD.org/cgi/query-pr.cgi?pr=27906 State-Changed-From-To: open->closed State-Changed-By: julian State-Changed-When: Fri Jul 13 23:03:00 PDT 2001 State-Changed-Why: Patch committed http://www.FreeBSD.org/cgi/query-pr.cgi?pr=27906 >Unformatted: Patch was correct. applied to code. (I'd like to know what the submitter is doing with netgraph that showed this ommision)