From nobody@FreeBSD.org Tue Jun 16 13:04:00 2009 Return-Path: Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id DD0B2106566B for ; Tue, 16 Jun 2009 13:04:00 +0000 (UTC) (envelope-from nobody@FreeBSD.org) Received: from www.freebsd.org (www.freebsd.org [IPv6:2001:4f8:fff6::21]) by mx1.freebsd.org (Postfix) with ESMTP id CB2908FC1C for ; Tue, 16 Jun 2009 13:04:00 +0000 (UTC) (envelope-from nobody@FreeBSD.org) Received: from www.freebsd.org (localhost [127.0.0.1]) by www.freebsd.org (8.14.3/8.14.3) with ESMTP id n5GD40ZW016370 for ; Tue, 16 Jun 2009 13:04:00 GMT (envelope-from nobody@www.freebsd.org) Received: (from nobody@localhost) by www.freebsd.org (8.14.3/8.14.3/Submit) id n5GD40kg016369; Tue, 16 Jun 2009 13:04:00 GMT (envelope-from nobody) Message-Id: <200906161304.n5GD40kg016369@www.freebsd.org> Date: Tue, 16 Jun 2009 13:04:00 GMT From: Yoshikazu GOTO To: freebsd-gnats-submit@FreeBSD.org Subject: Please adding a entry for USB Mass Storage Device to umass.c X-Send-Pr-Version: www-3.1 X-GNATS-Notify: >Number: 135628 >Category: kern >Synopsis: [umass] [patch] add a device quirk for Myson Heden 8813 >Confidential: no >Severity: non-critical >Priority: medium >Responsible: remko >State: closed >Quarter: >Keywords: >Date-Required: >Class: update >Submitter-Id: current-users >Arrival-Date: Tue Jun 16 13:10:01 UTC 2009 >Closed-Date: Thu Jan 27 19:37:32 UTC 2011 >Last-Modified: Thu Jan 27 19:40:10 UTC 2011 >Originator: Yoshikazu GOTO >Release: FreeBSD 7-STABLE >Organization: none >Environment: FreeBSD sakura.on-link.jp 7.2-STABLE FreeBSD 7.2-STABLE #1: Tue Jun 16 09:17:06 JST 2009 root@sakura.on-link.jp:/usr/fs/src/sys/i386/compile/KERNEL.SAKURA i386 >Description: I would like to use a USB Mass Storage Device. Please add one entry to "umass.c". ---- usbdevs -v ---- Controller /dev/usb6: addr 1: high speed, self powered, config 1, EHCI root hub(0x0000), Intel(0x0000), rev 1.00 port 1 addr 2: high speed, self powered, config 1, USB Mass Storage Device(0x8813), Myson Century, Inc.(0x04cf), rev a0.01 ---- ---- camcontrol inquiry ---- pass0: Fixed Direct Access SCSI-0 device pass0: Serial Number 40.000MB/s transfers ---- ---- error messages ---- (da0:umass-sim0:0:0:0): SYNCHRONIZE CACHE(10). CDB: 35 0 0 0 0 0 0 0 0 0 (da0:umass-sim0:0:0:0): CAM Status: SCSI Status Error (da0:umass-sim0:0:0:0): SCSI Status: Check Condition (da0:umass-sim0:0:0:0): ILLEGAL REQUEST asc:20,0 (da0:umass-sim0:0:0:0): Invalid command operation code (da0:umass-sim0:0:0:0): Unretryable error ---- ---- dmesg ---- uhub6: on usb6 uhub6: 6 ports with 6 removable, self powered umass0: on uhub6 da0 at umass-sim0 bus 0 target 0 lun 0 da0: Fixed Direct Access SCSI-0 device da0: 40.000MB/s transfers da0: 305245MB (625142448 512 byte sectors: 255H 63S/T 38913C) ---- >How-To-Repeat: >Fix: $ diff umass.c umass.c.new 569a570,573 > { USB_VENDOR_MYSON, USB_PRODUCT_MYSON_HEDEN8813, RID_WILDCARD, > UMASS_PROTO_SCSI | UMASS_PROTO_BBB, > NO_SYNCHRONIZE_CACHE > }, >Release-Note: >Audit-Trail: Responsible-Changed-From-To: freebsd-bugs->freebsd-usb Responsible-Changed-By: vwe Responsible-Changed-When: Tue Jun 16 20:27:48 UTC 2009 Responsible-Changed-Why: Over to maintainer(s). BTW, please use real (unified prefered) diffs and not just snippets of a diff, thanks. http://www.freebsd.org/cgi/query-pr.cgi?pr=135628 From: Yoshikazu GOTO To: volker@vwsoft.com Cc: bug-followup@FreeBSD.org, Yoshikazu GOTO Subject: Re: kern/135628: [umass] add a device quirk for Myson Heden 8813 Date: Wed, 17 Jun 2009 07:33:11 +0900 (JST) In Message-ID: <1245184715.63130.3.camel@dardanos.sz.vwsoft.com> vwe wrote : > Here're the correct patches (not tested, modifications according to > information contained in the PR). Thanks for your work. I read your diffs and It works for me. And I am sorry for my incomplete patches. Goto. -=-=-=- // // Yoshikazu GOTO (Snowy Project) // -=-=-=- \e From: vwe To: bug-followup@FreeBSD.org, goto@on-link.jp Cc: Subject: Re: kern/135628: [umass] add a device quirk for Myson Heden 8813 Date: Tue, 16 Jun 2009 22:38:35 +0200 --=-IEGiTeIssyoG26mEnauD Content-Type: text/plain Content-Transfer-Encoding: 7bit Here're the correct patches (not tested, modifications according to information contained in the PR). --=-IEGiTeIssyoG26mEnauD Content-Disposition: attachment; filename="umass.c.diff" Content-Type: text/x-patch; name="umass.c.diff"; charset="us-ascii" Content-Transfer-Encoding: 7bit --- umass.c.orig 2009-06-16 22:34:01.000000000 +0200 +++ umass.c 2009-06-16 22:35:36.000000000 +0200 @@ -571,6 +571,10 @@ UMASS_PROTO_SCSI | UMASS_PROTO_BBB, NO_INQUIRY | IGNORE_RESIDUE | NO_SYNCHRONIZE_CACHE }, + { USB_VENDOR_MYSON, USB_PRODUCT_MYSON_HEDEN_B, RID_WILDCARD, + UMASS_PROTO_SCSI | UMASS_PROTO_BBB, + NO_SYNCHRONIZE_CACHE + }, { USB_VENDOR_MYSON, USB_PRODUCT_MYSON_STARREADER, RID_WILDCARD, UMASS_PROTO_SCSI | UMASS_PROTO_BBB, NO_SYNCHRONIZE_CACHE --=-IEGiTeIssyoG26mEnauD Content-Disposition: attachment; filename="usbdevs.diff" Content-Type: text/x-patch; name="usbdevs.diff"; charset="us-ascii" Content-Transfer-Encoding: 7bit --- usbdevs.orig 2009-06-16 22:32:17.000000000 +0200 +++ usbdevs 2009-06-16 22:33:46.000000000 +0200 @@ -1814,6 +1814,7 @@ /* Myson products */ product MYSON HEDEN 0x8818 USB-IDE +product MYSON HEDEN_B 0x8813 USB-IDE product MYSON STARREADER 0x9920 USB flash card adapter /* National Semiconductor */ --=-IEGiTeIssyoG26mEnauD-- Responsible-Changed-From-To: freebsd-usb->remko Responsible-Changed-By: remko Responsible-Changed-When: Sun Jun 21 09:58:06 UTC 2009 Responsible-Changed-Why: I already prepared a patch for usbdevs and umass.c (8813 is not yet known). This will soak in head first and then it will be MFC'ed at some point. http://www.freebsd.org/cgi/query-pr.cgi?pr=135628 State-Changed-From-To: open->patched State-Changed-By: remko State-Changed-When: Sun Jun 21 11:25:22 UTC 2009 State-Changed-Why: Patch committed to head with additional usbdevs update. http://www.freebsd.org/cgi/query-pr.cgi?pr=135628 From: dfilter@FreeBSD.ORG (dfilter service) To: bug-followup@FreeBSD.org Cc: Subject: Re: kern/135628: commit references a PR Date: Sun, 21 Jun 2009 11:21:31 +0000 (UTC) Author: remko Date: Sun Jun 21 11:21:16 2009 New Revision: 194582 URL: http://svn.freebsd.org/changeset/base/194582 Log: Add support for the Myson Heden 8813. Note that I also added the usbdev to the list, because the 8813 version is not yet known there. I might have twisted the sorting there but because 8813 comes before 8818, I added it before that (with _8813 to differentiate) the item. PR: 135628 Submitted by: Yoshikazu GOTO Approved by: imp (mentor, implicit) Modified: head/sys/dev/usb/storage/umass.c head/sys/dev/usb/usbdevs Modified: head/sys/dev/usb/storage/umass.c ============================================================================== --- head/sys/dev/usb/storage/umass.c Sun Jun 21 10:29:31 2009 (r194581) +++ head/sys/dev/usb/storage/umass.c Sun Jun 21 11:21:16 2009 (r194582) @@ -629,6 +629,10 @@ static const struct umass_devdescr umass UMASS_PROTO_DEFAULT, IGNORE_RESIDUE | NO_SYNCHRONIZE_CACHE }, + {USB_VENDOR_MYSON, USB_PRODUCT_MYSON_HEDEN_8813, RID_WILDCARD, + UMASS_PROTO_SCSI | UMASS_PROTO_BBB, + NO_SYNCHRONIZE_CACHE + }, {USB_VENDOR_MYSON, USB_PRODUCT_MYSON_STARREADER, RID_WILDCARD, UMASS_PROTO_DEFAULT, NO_SYNCHRONIZE_CACHE Modified: head/sys/dev/usb/usbdevs ============================================================================== --- head/sys/dev/usb/usbdevs Sun Jun 21 10:29:31 2009 (r194581) +++ head/sys/dev/usb/usbdevs Sun Jun 21 11:21:16 2009 (r194582) @@ -1819,6 +1819,7 @@ product MSYSTEMS DISKONKEY 0x0010 DiskOn product MSYSTEMS DISKONKEY2 0x0011 DiskOnKey /* Myson products */ +product MYSON HEDEN_8813 0x8813 USB-IDE product MYSON HEDEN 0x8818 USB-IDE product MYSON STARREADER 0x9920 USB flash card adapter _______________________________________________ svn-src-all@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/svn-src-all To unsubscribe, send any mail to "svn-src-all-unsubscribe@freebsd.org" State-Changed-From-To: patched->closed State-Changed-By: remko State-Changed-When: Thu Jan 27 19:37:31 UTC 2011 State-Changed-Why: finally merged :) thanks for waiting. http://www.freebsd.org/cgi/query-pr.cgi?pr=135628 From: dfilter@FreeBSD.ORG (dfilter service) To: bug-followup@FreeBSD.org Cc: Subject: Re: kern/135628: commit references a PR Date: Thu, 27 Jan 2011 19:37:10 +0000 (UTC) Author: remko Date: Thu Jan 27 19:37:01 2011 New Revision: 217970 URL: http://svn.freebsd.org/changeset/base/217970 Log: MFC r194582 Add support for the Myson Heden 8813. Note that I also added the usbdev to the list, because the 8813 version is not yet known there. I might have twisted the sorting there but because 8813 comes before 8818, I added it before that (with _8813 to differentiate) the item. PR: 135628 Submitted by: Yoshikazu GOTO Approved by: imp (mentor, implicit) PR: 135628 Modified: stable/7/sys/dev/usb/umass.c stable/7/sys/dev/usb/usbdevs Directory Properties: stable/7/sys/dev/usb/ (props changed) Modified: stable/7/sys/dev/usb/umass.c ============================================================================== --- stable/7/sys/dev/usb/umass.c Thu Jan 27 19:33:57 2011 (r217969) +++ stable/7/sys/dev/usb/umass.c Thu Jan 27 19:37:01 2011 (r217970) @@ -571,6 +571,10 @@ static struct umass_devdescr_t umass_dev UMASS_PROTO_SCSI | UMASS_PROTO_BBB, NO_INQUIRY | IGNORE_RESIDUE | NO_SYNCHRONIZE_CACHE }, + { USB_VENDOR_MYSON, USB_PRODUCT_MYSON_HEDEN_8813, RID_WILDCARD, + UMASS_PROTO_SCSI | UMASS_PROTO_BBB, + NO_SYNCHRONIZE_CACHE + }, { USB_VENDOR_MYSON, USB_PRODUCT_MYSON_STARREADER, RID_WILDCARD, UMASS_PROTO_SCSI | UMASS_PROTO_BBB, NO_SYNCHRONIZE_CACHE Modified: stable/7/sys/dev/usb/usbdevs ============================================================================== --- stable/7/sys/dev/usb/usbdevs Thu Jan 27 19:33:57 2011 (r217969) +++ stable/7/sys/dev/usb/usbdevs Thu Jan 27 19:37:01 2011 (r217970) @@ -1837,6 +1837,7 @@ product MSYSTEMS DISKONKEY 0x0010 DiskOn product MSYSTEMS DISKONKEY2 0x0011 DiskOnKey /* Myson products */ +product MYSON HEDEN_8813 0x8813 USB-IDE product MYSON HEDEN 0x8818 USB-IDE product MYSON STARREADER 0x9920 USB flash card adapter _______________________________________________ svn-src-all@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/svn-src-all To unsubscribe, send any mail to "svn-src-all-unsubscribe@freebsd.org" From: dfilter@FreeBSD.ORG (dfilter service) To: bug-followup@FreeBSD.org Cc: Subject: Re: kern/135628: commit references a PR Date: Thu, 27 Jan 2011 19:37:10 +0000 (UTC) Author: remko Date: Thu Jan 27 19:37:01 2011 New Revision: 217970 URL: http://svn.freebsd.org/changeset/base/217970 Log: MFC r194582 Add support for the Myson Heden 8813. Note that I also added the usbdev to the list, because the 8813 version is not yet known there. I might have twisted the sorting there but because 8813 comes before 8818, I added it before that (with _8813 to differentiate) the item. PR: 135628 Submitted by: Yoshikazu GOTO Approved by: imp (mentor, implicit) PR: 135628 Modified: stable/7/sys/dev/usb/umass.c stable/7/sys/dev/usb/usbdevs Directory Properties: stable/7/sys/dev/usb/ (props changed) Modified: stable/7/sys/dev/usb/umass.c ============================================================================== --- stable/7/sys/dev/usb/umass.c Thu Jan 27 19:33:57 2011 (r217969) +++ stable/7/sys/dev/usb/umass.c Thu Jan 27 19:37:01 2011 (r217970) @@ -571,6 +571,10 @@ static struct umass_devdescr_t umass_dev UMASS_PROTO_SCSI | UMASS_PROTO_BBB, NO_INQUIRY | IGNORE_RESIDUE | NO_SYNCHRONIZE_CACHE }, + { USB_VENDOR_MYSON, USB_PRODUCT_MYSON_HEDEN_8813, RID_WILDCARD, + UMASS_PROTO_SCSI | UMASS_PROTO_BBB, + NO_SYNCHRONIZE_CACHE + }, { USB_VENDOR_MYSON, USB_PRODUCT_MYSON_STARREADER, RID_WILDCARD, UMASS_PROTO_SCSI | UMASS_PROTO_BBB, NO_SYNCHRONIZE_CACHE Modified: stable/7/sys/dev/usb/usbdevs ============================================================================== --- stable/7/sys/dev/usb/usbdevs Thu Jan 27 19:33:57 2011 (r217969) +++ stable/7/sys/dev/usb/usbdevs Thu Jan 27 19:37:01 2011 (r217970) @@ -1837,6 +1837,7 @@ product MSYSTEMS DISKONKEY 0x0010 DiskOn product MSYSTEMS DISKONKEY2 0x0011 DiskOnKey /* Myson products */ +product MYSON HEDEN_8813 0x8813 USB-IDE product MYSON HEDEN 0x8818 USB-IDE product MYSON STARREADER 0x9920 USB flash card adapter _______________________________________________ svn-src-all@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/svn-src-all To unsubscribe, send any mail to "svn-src-all-unsubscribe@freebsd.org" >Unformatted: