From byron@thrush.omix.com Tue Apr 11 08:26:50 2000 Return-Path: Received: from thrush.omix.com (thrush.omix.com [206.40.77.44]) by hub.freebsd.org (Postfix) with ESMTP id 17ADC37B9C5 for ; Tue, 11 Apr 2000 08:26:50 -0700 (PDT) (envelope-from byron@thrush.omix.com) Received: (from byron@localhost) by thrush.omix.com (8.9.3/8.9.2) id IAA94047; Tue, 11 Apr 2000 08:29:22 -0700 (PDT) (envelope-from byron) Message-Id: <200004111529.IAA94047@thrush.omix.com> Date: Tue, 11 Apr 2000 08:29:22 -0700 (PDT) From: byron@omix.com Sender: byron@thrush.omix.com Reply-To: byron@omix.com To: FreeBSD-gnats-submit@freebsd.org Subject: pccardd uses /etc/pccard.conf.sample when man page says /etc/pccard.conf X-Send-Pr-Version: 3.2 >Number: 17929 >Category: conf >Synopsis: pccardd uses /etc/pccard.conf.sample when man page says /etc/pccard.conf >Confidential: no >Severity: non-critical >Priority: low >Responsible: iwasaki >State: closed >Quarter: >Keywords: >Date-Required: >Class: doc-bug >Submitter-Id: current-users >Arrival-Date: Tue Apr 11 08:30:01 PDT 2000 >Closed-Date: Sat Apr 15 04:20:04 PDT 2000 >Last-Modified: Sat Apr 15 04:24:18 PDT 2000 >Originator: Byron Brummer (aka Zenin) >Release: FreeBSD 4.0-RELEASE i386 >Organization: >Environment: ThinkPad 600 laptop. >Description: The man page for pccard(8) says the default configuration file is /etc/pccard.conf, which is false. /etc/defaults/rc.conf changes the config to be /etc/pccard.conf.sample, effectively changing the default for all practical use. As the file is marked .sample and there is no man page for pccard.conf.sample, I assumed it was the same as the /etc/ppp/ppp.shells.sample and similar files (such as those often placed into /usr/local/etc/rc.d/*.sample). That is, the intension is that the file must be copied into place before it's usable; that it's just a sample file, not the real thing. I was wrong. /etc/defaults/rc.conf "magically" changes this perception, breaking the .sample convention used throughout the system, and causing a great amount of confusion when none of my changes in /etc/pccard.conf had any effect. This wasn't the case in earlier releases and it shouldn't be the case now, IMHO. >How-To-Repeat: Copy /etc/pccard.conf.sample to /etc/pccard.conf as one would expect to be the way to do things. Change something in /etc/pccard.conf and watch pccardd simply ignore your changes. >Fix: Set the pccard_conf variable in /etc/defaults/rc.conf to point to /etc/pccard.conf. Either copy or better yet move /etc/pccard.conf.sample to /etc/pccard.conf. >Release-Note: >Audit-Trail: From: Brooks Davis To: byron@omix.com Cc: FreeBSD-gnats-submit@FreeBSD.ORG Subject: Re: conf/17929: pccardd uses /etc/pccard.conf.sample when man page says /etc/pccard.conf Date: Tue, 11 Apr 2000 10:15:51 -0700 On Tue, Apr 11, 2000 at 08:29:22AM -0700, byron@omix.com wrote: > >Description: > > The man page for pccard(8) says the default configuration file is > /etc/pccard.conf, which is false. /etc/defaults/rc.conf changes > the config to be /etc/pccard.conf.sample, effectively changing the > default for all practical use. > > As the file is marked .sample and there is no man page for > pccard.conf.sample, I assumed it was the same as the > /etc/ppp/ppp.shells.sample and similar files (such as those > often placed into /usr/local/etc/rc.d/*.sample). That is, the > intension is that the file must be copied into place before it's > usable; that it's just a sample file, not the real thing. > > I was wrong. > > /etc/defaults/rc.conf "magically" changes this perception, breaking > the .sample convention used throughout the system, and causing a > great amount of confusion when none of my changes in > /etc/pccard.conf had any effect. > > This wasn't the case in earlier releases and it shouldn't be the > case now, IMHO. This PR is obsolete. The new configuration method in -current makes the system read /etc/defaults/pccard.conf which in turn read /etc/pccard.conf to provide override support. This is the solution which should be adopted in 4.0. -- Brooks -- Any statement of the form "X is the one, true Y" is FALSE. From: byron@omix.com (Byron Brummer) To: Brooks Davis Cc: byron@omix.com, FreeBSD-gnats-submit@FreeBSD.ORG Subject: Re: conf/17929: pccardd uses /etc/pccard.conf.sample when man page says /etc/pccard.conf Date: Tue, 11 Apr 2000 10:23:33 -0700 (PDT) Brooks Davis wrote: > On Tue, Apr 11, 2000 at 08:29:22AM -0700, byron@omix.com wrote: > > The man page for pccard(8) says the default configuration file is > > /etc/pccard.conf, which is false. /etc/defaults/rc.conf changes > > the config to be /etc/pccard.conf.sample, effectively changing the > > default for all practical use. >snip< > This PR is obsolete. The new configuration method in -current makes the > system read /etc/defaults/pccard.conf which in turn read > /etc/pccard.conf to provide override support. This is the solution > which should be adopted in 4.0. How recently was this done? 4.0-RELEASE isn't all that old. Has the above been moved to -stable? -Byron From: Brooks Davis To: Byron Brummer Cc: FreeBSD-gnats-submit@FreeBSD.ORG, imp@FreeBSD.ORG, iwasaki@FreeBSD.ORG Subject: Re: conf/17929: pccardd uses /etc/pccard.conf.sample when man page says /etc/pccard.conf Date: Tue, 11 Apr 2000 10:39:57 -0700 On Tue, Apr 11, 2000 at 10:23:33AM -0700, Byron Brummer wrote: > Brooks Davis wrote: > > On Tue, Apr 11, 2000 at 08:29:22AM -0700, byron@omix.com wrote: > > > The man page for pccard(8) says the default configuration file is > > > /etc/pccard.conf, which is false. /etc/defaults/rc.conf changes > > > the config to be /etc/pccard.conf.sample, effectively changing the > > > default for all practical use. > >snip< > > This PR is obsolete. The new configuration method in -current makes the > > system read /etc/defaults/pccard.conf which in turn read > > /etc/pccard.conf to provide override support. This is the solution > > which should be adopted in 4.0. > > How recently was this done? 4.0-RELEASE isn't all that old. Has > the above been moved to -stable? It was done on April 3. I suspect it will be merged, but it hasn't been yet. I've CCed the PC Card maintainers for a definitive answer. -- Brooks -- Any statement of the form "X is the one, true Y" is FALSE. From: Warner Losh To: Brooks Davis Cc: Byron Brummer , FreeBSD-gnats-submit@FreeBSD.ORG, iwasaki@FreeBSD.ORG Subject: Re: conf/17929: pccardd uses /etc/pccard.conf.sample when man page says /etc/pccard.conf Date: Tue, 11 Apr 2000 11:41:47 -0600 In message <20000411103957.B20344@orion.ac.hmc.edu> Brooks Davis writes: : It was done on April 3. I suspect it will be merged, but it hasn't been : yet. I've CCed the PC Card maintainers for a definitive answer. I think that the best thing to do is wait for iwasaki-san to clear his queue of patches, then do one mega back commit all at once. Warner Responsible-Changed-From-To: freebsd-bugs->iwasaki Responsible-Changed-By: jkoshy Responsible-Changed-When: Thu Apr 13 21:59:06 PDT 2000 Responsible-Changed-Why: Over to maintainer. State-Changed-From-To: open->closed State-Changed-By: iwasaki State-Changed-When: Sat Apr 15 04:20:04 PDT 2000 State-Changed-Why: The pccardd default config file is changed to /etc/defaults/pccard.conf. /etc/pccard.conf.sample is no longer used in -CURRENT/STABLE. Thanks! >Unformatted: