From dan@obluda.cz Sun Sep 12 02:37:56 2004 Return-Path: Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id C463116A4CE for ; Sun, 12 Sep 2004 02:37:56 +0000 (GMT) Received: from kulesh.obluda.cz (kulesh.obluda.cz [193.179.22.243]) by mx1.FreeBSD.org (Postfix) with ESMTP id 958F543D39 for ; Sun, 12 Sep 2004 02:37:55 +0000 (GMT) (envelope-from dan@obluda.cz) Received: from kulesh.obluda.cz (localhost.eunet.cz [127.0.0.1]) by kulesh.obluda.cz (8.13.1/8.13.1) with ESMTP id i8C2bsU9007105 for ; Sun, 12 Sep 2004 04:37:54 +0200 (CEST) (envelope-from dan@obluda.cz) Received: (from root@localhost) by kulesh.obluda.cz (8.13.1/8.13.1/Submit) id i8C2brW3007104 for FreeBSD-gnats-submit@freebsd.org; Sun, 12 Sep 2004 04:37:53 +0200 (CEST) (envelope-from dan@obluda.cz) Message-Id: <200409120237.i8C2brW3007104@kulesh.obluda.cz> Date: Sun, 12 Sep 2004 04:37:53 +0200 (CEST) From: Dan Lukes Reply-To: Dan Lukes To: FreeBSD-gnats-submit@freebsd.org Cc: Subject: [PATCH] cleanup of the usr.sbin/sicontrol code X-Send-Pr-Version: 3.113 X-GNATS-Notify: >Number: 71622 >Category: bin >Synopsis: [patch] sicontrol(8): cleanup of the usr.sbin/sicontrol code >Confidential: no >Severity: non-critical >Priority: low >Responsible: freebsd-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: sw-bug >Submitter-Id: current-users >Arrival-Date: Sun Sep 12 02:40:26 GMT 2004 >Closed-Date: >Last-Modified: Mon Dec 29 18:00:22 UTC 2008 >Originator: Dan Lukes >Release: FreeBSD 5.3-BETA3 i386 >Organization: Obludarium >Environment: System: FreeBSD kulesh.obluda.cz 5.3-BETA3 FreeBSD 5.3-BETA3 #8: Sun Sep 5 07:06:40 CEST 2004 dan@kulesh.obluda.cz:/usr/obj/usr/src/sys/Dan i386 usr.sbin/sicontrol/sicontrol.c,v 1.14 2004/08/07 04:28:55 imp >Description: There are more than 5000 warnings issued during "make buildworld". Some of them are false positives, but some of them are sign of true errors. Nobody is upset by warnings due it's amount, so some errors remain uncorrected. I want to cleanup the code-base from warnings, so warnings will become "attention mark" again. usr.sbin/sicontrol/sicontrol.c:472: warning: unsigned int format, pointer arg (arg 2) >How-To-Repeat: N/A >Fix: *** usr.sbin/sicontrol/sicontrol.c.ORIG Sun Aug 8 21:14:06 2004 --- usr.sbin/sicontrol/sicontrol.c Tue Sep 7 19:26:59 2004 *************** *** 469,475 **** printf("%s: ", Devname); printf("\tt_outq.c_cc %d.\n", TTY.t_outq.c_cc); /* struct clist t_outq */ ! printf("\tt_dev 0x%x\n", TTY.t_dev); /* dev_t t_dev */ printf("\tt_flags 0x%x\n", TTY.t_flags); /* int t_flags */ printf("\tt_state 0x%x\n", TTY.t_state); /* int t_state */ printf("\tt_ihiwat %d.\n", TTY.t_ihiwat); /* int t_ihiwat */ --- 469,475 ---- printf("%s: ", Devname); printf("\tt_outq.c_cc %d.\n", TTY.t_outq.c_cc); /* struct clist t_outq */ ! printf("\tt_dev %p\n", TTY.t_dev); /* struct cdev *t_dev */ printf("\tt_flags 0x%x\n", TTY.t_flags); /* int t_flags */ printf("\tt_state 0x%x\n", TTY.t_state); /* int t_state */ printf("\tt_ihiwat %d.\n", TTY.t_ihiwat); /* int t_ihiwat */ >Release-Note: >Audit-Trail: >Unformatted: