From tl@sie-home-2-12.urbanet.ch Thu May 25 01:54:03 2000 Return-Path: Received: from sie-home-2-12.urbanet.ch (sie-home-2-12.urbanet.ch [194.38.83.108]) by hub.freebsd.org (Postfix) with ESMTP id A43BE37BB00 for ; Thu, 25 May 2000 01:54:01 -0700 (PDT) (envelope-from tl@sie-home-2-12.urbanet.ch) Received: (from tl@localhost) by sie-home-2-12.urbanet.ch (8.9.3/8.9.3) id KAA00691; Thu, 25 May 2000 10:54:29 +0200 (CEST) (envelope-from tl) Message-Id: <200005250854.KAA00691@sie-home-2-12.urbanet.ch> Date: Thu, 25 May 2000 10:54:29 +0200 (CEST) From: tludwig@urbanet.ch Sender: tl@sie-home-2-12.urbanet.ch Reply-To: tludwig@urbanet.ch To: FreeBSD-gnats-submit@freebsd.org Subject: error in usr.bin/ftp/main.c ? X-Send-Pr-Version: 3.2 >Number: 18804 >Category: bin >Synopsis: error in usr.bin/ftp/main.c ? >Confidential: no >Severity: non-critical >Priority: medium >Responsible: freebsd-bugs >State: closed >Quarter: >Keywords: >Date-Required: >Class: sw-bug >Submitter-Id: current-users >Arrival-Date: Thu May 25 02:00:01 PDT 2000 >Closed-Date: Tue May 29 02:26:57 PDT 2001 >Last-Modified: Tue May 29 02:27:13 PDT 2001 >Originator: Thomas Ludwig >Release: FreeBSD 4.0-STABLE i386 >Organization: >Environment: FreeBSD sie-home-2-12.urbanet.ch 4.0-STABLE FreeBSD 4.0-STABLE #0: Wed May 3 18:01:35 CEST 2000 root@sie-home-2-12.urbanet.ch:/usr/obj/usr/src/sys/BOLZA i386 >Description: in usr.bin/ftp/main.c at line 407, there is a test for a newline character in a string pointed to by the variable 'line'. if (line[--num] == '\n') { Unfortunately the string that should be checked is pointed to by 'line', not 'buf'. >How-To-Repeat: >Fix: replace line 407 in usr.bin/ftp/main.c by if (buf[--num] == '\n') { >Release-Note: >Audit-Trail: From: Alexander Langer To: tludwig@urbanet.ch Cc: FreeBSD-gnats-submit@FreeBSD.ORG Subject: Re: bin/18804: error in usr.bin/ftp/main.c ? Date: Thu, 25 May 2000 11:28:22 +0200 Also sprach tludwig@urbanet.ch (tludwig@urbanet.ch): > if (line[--num] == '\n') { > Unfortunately the string that should be checked is > pointed to by 'line', not 'buf'. It seems as if you are right. The following occurencies of line must be changed to buf then, too, up to the memcpy. Alex State-Changed-From-To: open->closed State-Changed-By: phk State-Changed-When: Tue May 29 02:26:57 PDT 2001 State-Changed-Why: fixed in rev 1.27 by se. http://www.FreeBSD.org/cgi/query-pr.cgi?pr=18804 >Unformatted: