class RuboCop::Cop::Style::AndOr
This cop checks for uses of and and or.
Constants
- MSG
- OPS
Public Instance Methods
on_and(node)
click to toggle source
# File lib/rubocop/cop/style/and_or.rb, line 14 def on_and(node) process_logical_op(node) if style == :always end
on_if(node)
click to toggle source
# File lib/rubocop/cop/style/and_or.rb, line 22 def on_if(node) on_conditionals(node) if style == :conditionals end
on_or(node)
click to toggle source
# File lib/rubocop/cop/style/and_or.rb, line 18 def on_or(node) process_logical_op(node) if style == :always end
on_until(node)
click to toggle source
# File lib/rubocop/cop/style/and_or.rb, line 34 def on_until(node) on_conditionals(node) if style == :conditionals end
on_until_post(node)
click to toggle source
# File lib/rubocop/cop/style/and_or.rb, line 38 def on_until_post(node) on_conditionals(node) if style == :conditionals end
on_while(node)
click to toggle source
# File lib/rubocop/cop/style/and_or.rb, line 26 def on_while(node) on_conditionals(node) if style == :conditionals end
on_while_post(node)
click to toggle source
# File lib/rubocop/cop/style/and_or.rb, line 30 def on_while_post(node) on_conditionals(node) if style == :conditionals end
Private Instance Methods
autocorrect(node)
click to toggle source
# File lib/rubocop/cop/style/and_or.rb, line 60 def autocorrect(node) expr1, expr2 = *node replacement = (node.type == :and ? '&&' : '||') lambda do |corrector| [expr1, expr2].each do |expr| if expr.send_type? correct_send(expr, corrector) elsif expr.return_type? correct_other(expr, corrector) elsif expr.assignment? correct_other(expr, corrector) end end corrector.replace(node.loc.operator, replacement) end end
correct_not(node, receiver, corrector)
click to toggle source
! is a special case: 'x and !obj.method arg' can be auto-corrected if we recurse down a level and add parens to 'obj.method arg' however, 'not x' also parses as (send x :!)
# File lib/rubocop/cop/style/and_or.rb, line 90 def correct_not(node, receiver, corrector) if node.loc.selector.source == '!' return unless receiver.send_type? correct_send(receiver, corrector) elsif node.keyword_not? correct_other(node, corrector) else raise 'unrecognized unary negation operator' end end
correct_other(node, corrector)
click to toggle source
# File lib/rubocop/cop/style/and_or.rb, line 102 def correct_other(node, corrector) return unless node.source_range.begin.source != '(' corrector.insert_before(node.source_range, '(') corrector.insert_after(node.source_range, ')') end
correct_send(node, corrector)
click to toggle source
# File lib/rubocop/cop/style/and_or.rb, line 77 def correct_send(node, corrector) receiver, method_name, *args = *node return correct_not(node, receiver, corrector) if method_name == :! return unless correctable_send?(node) corrector.replace(whitespace_before_arg(node), '('.freeze) corrector.insert_after(args.last.source_range, ')'.freeze) end
correctable_send?(node)
click to toggle source
# File lib/rubocop/cop/style/and_or.rb, line 108 def correctable_send?(node) _receiver, method_name, *args = *node # don't clobber if we already have a starting paren return false unless !node.loc.begin || node.loc.begin.source != '(' # don't touch anything unless we are sure it is a method call. return false unless args.last && method_name.to_s =~ /[a-z]/ true end
on_conditionals(node)
click to toggle source
# File lib/rubocop/cop/style/and_or.rb, line 44 def on_conditionals(node) condition_node, = *node condition_node.each_node(:and, :or) do |logical_node| process_logical_op(logical_node) end end
process_logical_op(node)
click to toggle source
# File lib/rubocop/cop/style/and_or.rb, line 52 def process_logical_op(node) op = node.loc.operator.source op_type = node.type.to_s return unless op == op_type add_offense(node, :operator, format(MSG, OPS[op], op)) end
whitespace_before_arg(node)
click to toggle source
# File lib/rubocop/cop/style/and_or.rb, line 118 def whitespace_before_arg(node) sb = node.source_range.source_buffer begin_paren = node.loc.selector.end_pos end_paren = begin_paren # Increment position of parenthesis, unless message is a predicate # method followed by a non-whitespace char (e.g. is_a?String). end_paren += 1 unless node.source =~ /\?[!\S]/ Parser::Source::Range.new(sb, begin_paren, end_paren) end