1 /***
2 * BSD-style license; for more info see http://pmd.sourceforge.net/license.html
3 */
4 package net.sourceforge.pmd.rules;
5
6 import net.sourceforge.pmd.AbstractRule;
7 import net.sourceforge.pmd.RuleContext;
8 import net.sourceforge.pmd.ast.ASTPrimitiveType;
9 import net.sourceforge.pmd.ast.ASTVariableDeclaratorId;
10 import net.sourceforge.pmd.ast.SimpleNode;
11 import net.sourceforge.pmd.symboltable.NameOccurrence;
12 import net.sourceforge.pmd.symboltable.VariableNameDeclaration;
13
14 import java.util.Iterator;
15 import java.util.List;
16 import java.util.Map;
17
18 public class StringToStringRule extends AbstractRule {
19
20 public Object visit(ASTVariableDeclaratorId node, Object data) {
21 SimpleNode nameNode = node.getTypeNameNode();
22 if (nameNode instanceof ASTPrimitiveType || !nameNode.getImage().equals("String")) {
23 return data;
24 }
25
26 Map decls = node.getScope().getVariableDeclarations(true);
27 for (Iterator i = decls.keySet().iterator(); i.hasNext();) {
28 VariableNameDeclaration decl = (VariableNameDeclaration) i.next();
29 if (!decl.getImage().equals(node.getImage())) {
30 continue;
31 }
32 List usages = (List) decls.get(decl);
33 for (Iterator j = usages.iterator(); j.hasNext();) {
34 NameOccurrence occ = (NameOccurrence) j.next();
35 if (occ.getNameForWhichThisIsAQualifier() != null && occ.getNameForWhichThisIsAQualifier().getImage().indexOf("toString") != -1) {
36 RuleContext ctx = (RuleContext) data;
37 ctx.getReport().addRuleViolation(createRuleViolation(ctx, occ.getBeginLine()));
38 }
39 }
40 }
41 return data;
42 }
43 }