From nobody@FreeBSD.org Mon Dec 22 15:51:16 2008 Return-Path: Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id CC455106568A for ; Mon, 22 Dec 2008 15:51:16 +0000 (UTC) (envelope-from nobody@FreeBSD.org) Received: from www.freebsd.org (www.freebsd.org [IPv6:2001:4f8:fff6::21]) by mx1.freebsd.org (Postfix) with ESMTP id BA7798FC1B for ; Mon, 22 Dec 2008 15:51:16 +0000 (UTC) (envelope-from nobody@FreeBSD.org) Received: from www.freebsd.org (localhost [127.0.0.1]) by www.freebsd.org (8.14.3/8.14.3) with ESMTP id mBMFpGvx092110 for ; Mon, 22 Dec 2008 15:51:16 GMT (envelope-from nobody@www.freebsd.org) Received: (from nobody@localhost) by www.freebsd.org (8.14.3/8.14.3/Submit) id mBMFpGfW092109; Mon, 22 Dec 2008 15:51:16 GMT (envelope-from nobody) Message-Id: <200812221551.mBMFpGfW092109@www.freebsd.org> Date: Mon, 22 Dec 2008 15:51:16 GMT From: Nick Triantos To: freebsd-gnats-submit@FreeBSD.org Subject: Need to add quirk to da_scsi.c to support StorCase SAN devices X-Send-Pr-Version: www-3.1 X-GNATS-Notify: >Number: 129858 >Category: usb >Synopsis: [usb] [patch] Need to add quirk to da_scsi.c to support StorCase SAN devices >Confidential: no >Severity: non-critical >Priority: low >Responsible: remko >State: closed >Quarter: >Keywords: >Date-Required: >Class: sw-bug >Submitter-Id: current-users >Arrival-Date: Mon Dec 22 16:00:04 UTC 2008 >Closed-Date: Thu Jan 27 20:50:50 UTC 2011 >Last-Modified: Thu Jan 27 21:00:23 UTC 2011 >Originator: Nick Triantos >Release: 7.0-RELEASE >Organization: >Environment: FreeBSD bsd.triantos.com 7.0-RELEASE-p3 FreeBSD 7.0-RELEASE-p3 #5: Tue Aug 19 22:58:55 PDT 2008 root@XXX.triantos.com:/usr/obj/usr/src/sys/BSD-TRIANTOS i386 >Description: I've got a StorCase InfoStation 12-bay SATA-to-FC SAN attached to my FreeBSD server. It turns out that this device does not support the SCSI cmds to sync its cache. The fix below adds the device to the list of those which require the "NO_SYNC_CACHE" quirk. >How-To-Repeat: Install a StorCase SAN and watch the sys logs >Fix: The patch below can be applied to /usr/src/sys/cam/scsi/da_scsi.c to fix this issue, but adding this storage system to the list of quirks. *** da_scsi.c.orig Tue Aug 19 00:03:43 2008 --- scsi_scsi.c Tue Aug 19 22:54:41 2008 *************** *** 535,540 **** --- 535,547 ---- {T_DIRECT, SIP_MEDIA_REMOVABLE, "ChipsBnk", "USB*", "*"}, /*quirks*/ DA_Q_NO_SYNC_CACHE }, + { + /* + * StorCase (Kingston) InfoStation IFS FC2/SATA-R 201A + */ + {T_DIRECT, SIP_MEDIA_FIXED, "IFS", "FC2/SATA-R*", "*"}, + /*quirks*/ DA_Q_NO_SYNC_CACHE + }, }; static disk_strategy_t dastrategy; >Release-Note: >Audit-Trail: Responsible-Changed-From-To: freebsd-bugs->freebsd-usb Responsible-Changed-By: linimon Responsible-Changed-When: Mon Dec 22 21:42:14 UTC 2008 Responsible-Changed-Why: Over to maintainer(s). http://www.freebsd.org/cgi/query-pr.cgi?pr=129858 Responsible-Changed-From-To: freebsd-usb->remko Responsible-Changed-By: remko Responsible-Changed-When: Tue Dec 23 09:11:18 UTC 2008 Responsible-Changed-Why: MFC reminder http://www.freebsd.org/cgi/query-pr.cgi?pr=129858 State-Changed-From-To: open->patched State-Changed-By: linimon State-Changed-When: Thu Dec 25 04:03:14 UTC 2008 State-Changed-Why: set as MFC reminder. http://www.freebsd.org/cgi/query-pr.cgi?pr=129858 From: Nick Triantos To: bug-followup@FreeBSD.org Cc: Subject: Re: usb/129858: [usb] [patch] Need to add quirk to da_scsi.c to support StorCase SAN devices Date: Mon, 4 May 2009 13:23:40 -0700 Hi, I see that this patch has been committed (status = patched), but I didn't find the patch in the 7.1 sources, nor in 7.2. To where has this code been committed? This is, IMO, a very low-risk change, so hopefully it can get into a release soon. PR link: http://www.freebsd.org/cgi/query-pr.cgi?pr=usb/129858 thanks very much, -Nick State-Changed-From-To: patched->closed State-Changed-By: remko State-Changed-When: Thu Jan 27 20:50:48 UTC 2011 State-Changed-Why: Finally imported into 7.. thanks for waiting! http://www.freebsd.org/cgi/query-pr.cgi?pr=129858 From: dfilter@FreeBSD.ORG (dfilter service) To: bug-followup@FreeBSD.org Cc: Subject: Re: usb/129858: commit references a PR Date: Thu, 27 Jan 2011 20:50:16 +0000 (UTC) Author: remko Date: Thu Jan 27 20:50:03 2011 New Revision: 217979 URL: http://svn.freebsd.org/changeset/base/217979 Log: MFC r186424 Add quirk for the Storcase InfoStation 12bay SATA to FC SAN. PR: 129858 Submitted by: Nick Triantos MFC after: 1 week PR: 129858 Modified: stable/7/sys/cam/scsi/scsi_da.c Directory Properties: stable/7/sys/cam/scsi/ (props changed) Modified: stable/7/sys/cam/scsi/scsi_da.c ============================================================================== --- stable/7/sys/cam/scsi/scsi_da.c Thu Jan 27 20:39:19 2011 (r217978) +++ stable/7/sys/cam/scsi/scsi_da.c Thu Jan 27 20:50:03 2011 (r217979) @@ -537,6 +537,14 @@ static struct da_quirk_entry da_quirk_ta }, { /* + * Storcase (Kingston) InfoStation IFS FC2/SATA-R 201A + * PR: 129858 + */ + {T_DIRECT, SIP_MEDIA_FIXED, "IFS", "FC2/SATA-R*", + "*"}, /*quirks*/ DA_Q_NO_SYNC_CACHE + }, + { + /* * Samsung YP-U3 mp3-player * PR: 125398 */ _______________________________________________ svn-src-all@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/svn-src-all To unsubscribe, send any mail to "svn-src-all-unsubscribe@freebsd.org" From: dfilter@FreeBSD.ORG (dfilter service) To: bug-followup@FreeBSD.org Cc: Subject: Re: usb/129858: commit references a PR Date: Thu, 27 Jan 2011 20:50:16 +0000 (UTC) Author: remko Date: Thu Jan 27 20:50:03 2011 New Revision: 217979 URL: http://svn.freebsd.org/changeset/base/217979 Log: MFC r186424 Add quirk for the Storcase InfoStation 12bay SATA to FC SAN. PR: 129858 Submitted by: Nick Triantos MFC after: 1 week PR: 129858 Modified: stable/7/sys/cam/scsi/scsi_da.c Directory Properties: stable/7/sys/cam/scsi/ (props changed) Modified: stable/7/sys/cam/scsi/scsi_da.c ============================================================================== --- stable/7/sys/cam/scsi/scsi_da.c Thu Jan 27 20:39:19 2011 (r217978) +++ stable/7/sys/cam/scsi/scsi_da.c Thu Jan 27 20:50:03 2011 (r217979) @@ -537,6 +537,14 @@ static struct da_quirk_entry da_quirk_ta }, { /* + * Storcase (Kingston) InfoStation IFS FC2/SATA-R 201A + * PR: 129858 + */ + {T_DIRECT, SIP_MEDIA_FIXED, "IFS", "FC2/SATA-R*", + "*"}, /*quirks*/ DA_Q_NO_SYNC_CACHE + }, + { + /* * Samsung YP-U3 mp3-player * PR: 125398 */ _______________________________________________ svn-src-all@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/svn-src-all To unsubscribe, send any mail to "svn-src-all-unsubscribe@freebsd.org" >Unformatted: