From uspoerlein@gmail.com Thu Oct 9 17:56:34 2008 Return-Path: Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 1F2AB1065693; Thu, 9 Oct 2008 17:56:34 +0000 (UTC) (envelope-from uspoerlein@gmail.com) Received: from acme.spoerlein.net (cl-43.dus-01.de.sixxs.net [IPv6:2a01:198:200:2a::2]) by mx1.freebsd.org (Postfix) with ESMTP id 8BCC18FC2D; Thu, 9 Oct 2008 17:56:33 +0000 (UTC) (envelope-from uspoerlein@gmail.com) Received: from roadrunner.spoerlein.net (e180139110.adsl.alicedsl.de [85.180.139.110]) by acme.spoerlein.net (8.14.2/8.14.2) with ESMTP id m99HuUi7065544 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Thu, 9 Oct 2008 19:56:32 +0200 (CEST) (envelope-from uspoerlein@gmail.com) Received: from roadrunner.spoerlein.net (localhost [127.0.0.1]) by roadrunner.spoerlein.net (8.14.2/8.14.2) with ESMTP id m99HuJoe001888 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Thu, 9 Oct 2008 19:56:19 +0200 (CEST) (envelope-from uqs@roadrunner.spoerlein.net) Received: (from uqs@localhost) by roadrunner.spoerlein.net (8.14.2/8.14.2/Submit) id m99HuJO7001887; Thu, 9 Oct 2008 19:56:19 +0200 (CEST) (envelope-from uqs) Message-Id: <200810091756.m99HuJO7001887@roadrunner.spoerlein.net> Date: Thu, 9 Oct 2008 19:56:19 +0200 (CEST) From: Ulrich Spörlein To: FreeBSD-gnats-submit@freebsd.org Cc: imp@freebsd.org Subject: [QUIRK] Fix Samsung YP U2 MP3 player on 7.x and 8.x X-Send-Pr-Version: 3.113 X-GNATS-Notify: >Number: 127980 >Category: usb >Synopsis: [umass] [patch] [usb67] Fix Samsung YP U2 MP3 player on 7.x and 8.x >Confidential: no >Severity: non-critical >Priority: low >Responsible: freebsd-usb >State: closed >Quarter: >Keywords: >Date-Required: >Class: change-request >Submitter-Id: current-users >Arrival-Date: Thu Oct 09 18:00:06 UTC 2008 >Closed-Date: Wed Aug 18 14:48:38 UTC 2010 >Last-Modified: Fri Nov 12 20:53:31 UTC 2010 >Originator: Ulrich Spoerlein >Release: FreeBSD 7.1-PRERELEASE i386 >Organization: >Environment: >Description: In the early days of RELENG_7 the quirk below was required to avoid timeouts with this MP3 player. But something changed in the USB code in the last few weeks, so that this device no longer attaches. I also tried -CURRENT from early august. It just stalls BBB transfers and I finally rebooted the box after two hours. Unplugging the device *always* leads to a panic, as it is stuck somewhere in CAM land. But I guess no one is interested in *that* backtrace ... >How-To-Repeat: >Fix: The fix is rather trivial: Remove the quirk and the device attaches successfully. (at least, if it is the only device on the bus) cf usb/114154 (which should be closed, btw) --- umass.diff begins here --- Index: sys/dev/usb/umass.c =================================================================== RCS file: /home/ncvs/src/sys/dev/usb/umass.c,v retrieving revision 1.160.2.4 diff -u -p -r1.160.2.4 umass.c --- sys/dev/usb/umass.c 28 Aug 2008 14:20:58 -0000 1.160.2.4 +++ sys/dev/usb/umass.c 8 Oct 2008 17:49:38 -0000 @@ -650,10 +650,6 @@ static struct umass_devdescr_t umass_dev UMASS_PROTO_SCSI | UMASS_PROTO_BBB, IGNORE_RESIDUE | NO_START_STOP }, - { USB_VENDOR_SAMSUNG, USB_PRODUCT_SAMSUNG_YP_U2, RID_WILDCARD, - UMASS_PROTO_SCSI | UMASS_PROTO_BBB, - SHUTTLE_INIT | NO_GETMAXLUN - }, { USB_VENDOR_SAMSUNG_TECHWIN, USB_PRODUCT_SAMSUNG_TECHWIN_DIGIMAX_410, RID_WILDCARD, UMASS_PROTO_SCSI | UMASS_PROTO_BBB, NO_INQUIRY Index: sys/dev/usb/usbdevs =================================================================== RCS file: /home/ncvs/src/sys/dev/usb/usbdevs,v retrieving revision 1.328.2.18 diff -u -p -r1.328.2.18 usbdevs --- sys/dev/usb/usbdevs 28 Aug 2008 14:20:58 -0000 1.328.2.18 +++ sys/dev/usb/usbdevs 9 Oct 2008 17:55:09 -0000 @@ -1989,7 +1989,6 @@ product SAGEM XG76NA 0x0062 XG-76NA /* Samsung products */ product SAMSUNG ML6060 0x3008 ML-6060 laser printer -product SAMSUNG YP_U2 0x5050 YP-U2 MP3 Player product SAMSUNG I500 0x6601 I500 Palm USB Phone /* Samsung Techwin products */ --- umass.diff ends here --- >Release-Note: >Audit-Trail: From: Ulrich =?utf-8?B?U3DDtnJsZWlu?= To: bug-followup@FreeBSD.org Cc: Harald Schmalzbauer Subject: Re: usb/127980: [umass] [patch] Fix Samsung YP U2 MP3 player on 7.x and 8.x Date: Mon, 24 Aug 2009 13:54:40 +0200 --ZGiS0Q5IWpPtfppv Content-Type: text/plain; charset=us-ascii Content-Disposition: inline New patch against the new USB stack. The problem is still valid, the quirk is only required on 6.x and is harmful on 7.x. Others have reported this problem, too. Please remove this quirk from head and RELENG_8 and RELENG_7, thanks! Uli --ZGiS0Q5IWpPtfppv Content-Type: text/x-diff; charset=us-ascii Content-Disposition: attachment; filename="samsung.diff" Index: sys/dev/usb/storage/umass.c =================================================================== --- sys/dev/usb/storage/umass.c (revision 196425) +++ sys/dev/usb/storage/umass.c (working copy) @@ -741,10 +741,6 @@ UMASS_PROTO_SCSI | UMASS_PROTO_BBB, IGNORE_RESIDUE | NO_START_STOP }, - {USB_VENDOR_SAMSUNG, USB_PRODUCT_SAMSUNG_YP_U2, RID_WILDCARD, - UMASS_PROTO_SCSI | UMASS_PROTO_BBB, - SHUTTLE_INIT | NO_GETMAXLUN - }, {USB_VENDOR_SAMSUNG_TECHWIN, USB_PRODUCT_SAMSUNG_TECHWIN_DIGIMAX_410, RID_WILDCARD, UMASS_PROTO_SCSI | UMASS_PROTO_BBB, NO_INQUIRY Index: sys/dev/usb/usbdevs =================================================================== --- sys/dev/usb/usbdevs (revision 196425) +++ sys/dev/usb/usbdevs (working copy) @@ -2108,7 +2108,6 @@ /* Samsung products */ product SAMSUNG ML6060 0x3008 ML-6060 laser printer -product SAMSUNG YP_U2 0x5050 YP-U2 MP3 Player product SAMSUNG I500 0x6601 I500 Palm USB Phone /* Samsung Techwin products */ --ZGiS0Q5IWpPtfppv-- State-Changed-From-To: open->patched State-Changed-By: gavin State-Changed-When: Tue Jul 27 13:49:28 UTC 2010 State-Changed-Why: This has been fixed in head and stable/8, mark as patched as the patch in the PR is likely correct for stable/7. http://www.freebsd.org/cgi/query-pr.cgi?pr=127980 State-Changed-From-To: patched->closed State-Changed-By: uqs State-Changed-When: Wed Aug 18 14:48:37 UTC 2010 State-Changed-Why: I no longer have this device, so I cannot test an MFC to stable/7. http://www.freebsd.org/cgi/query-pr.cgi?pr=127980 >Unformatted: