From nobody@FreeBSD.org Wed Apr 7 01:53:25 2010 Return-Path: Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id C1BD9106566B for ; Wed, 7 Apr 2010 01:53:25 +0000 (UTC) (envelope-from nobody@FreeBSD.org) Received: from www.freebsd.org (www.freebsd.org [IPv6:2001:4f8:fff6::21]) by mx1.freebsd.org (Postfix) with ESMTP id AFF098FC1B for ; Wed, 7 Apr 2010 01:53:25 +0000 (UTC) Received: from www.freebsd.org (localhost [127.0.0.1]) by www.freebsd.org (8.14.3/8.14.3) with ESMTP id o371rP0v061868 for ; Wed, 7 Apr 2010 01:53:25 GMT (envelope-from nobody@www.freebsd.org) Received: (from nobody@localhost) by www.freebsd.org (8.14.3/8.14.3/Submit) id o371rOjf061867; Wed, 7 Apr 2010 01:53:24 GMT (envelope-from nobody) Message-Id: <201004070153.o371rOjf061867@www.freebsd.org> Date: Wed, 7 Apr 2010 01:53:24 GMT From: Stefan Kuttler To: freebsd-gnats-submit@FreeBSD.org Subject: noticed a useless cat(1) in install.sh for ports X-Send-Pr-Version: www-3.1 X-GNATS-Notify: >Number: 145447 >Category: misc >Synopsis: [release] [patch] noticed a useless cat(1) in install.sh for ports >Confidential: no >Severity: non-critical >Priority: low >Responsible: freebsd-bugs >State: closed >Quarter: >Keywords: >Date-Required: >Class: sw-bug >Submitter-Id: current-users >Arrival-Date: Wed Apr 07 02:00:14 UTC 2010 >Closed-Date: Mon Jun 28 07:03:52 UTC 2010 >Last-Modified: Mon Jun 28 07:10:04 UTC 2010 >Originator: Stefan Kuttler >Release: FreeBSD 8.0-RELEASE #0 >Organization: nc.netbeisser.de >Environment: FreeBSD .localdomain 8.0-RELEASE FreeBSD 8.0-RELEASE #0: Sat Nov 21 15:48:17 UTC 2009 root@almeida.cse.buffalo.edu:/usr/obj/usr/src/sys/GENERIC i386 >Description: noticed a useless cat(1) in install.sh for ports: - cat ports.tgz | tar --unlink -xpzf - -C ${DESTDIR}/usr + tar --unlink -xpzf ports.tgz -C ${DESTDIR}/usr this works well for bsdtar. >How-To-Repeat: it works even without cat: # setenv DESTDIR / # tar --unlink -xpzf ports.tgz -C ${DESTDIR}/usr # echo $? 0 >Fix: remove cat(1) from install.sh >Release-Note: >Audit-Trail: Responsible-Changed-From-To: freebsd-ports-bugs->freebsd-bugs Responsible-Changed-By: linimon Responsible-Changed-When: Wed Apr 7 04:20:31 UTC 2010 Responsible-Changed-Why: Has to do with the release scripts. http://www.freebsd.org/cgi/query-pr.cgi?pr=145447 From: Mark Linimon To: bug-followup@FreeBSD.org Cc: Subject: Re: misc/145447: noticed a useless cat(1) in install.sh for ports Date: Tue, 6 Apr 2010 23:22:37 -0500 ----- Forwarded message from root ----- From: root To: Mark Linimon Subject: Re: ports/145447: noticed a useless cat(1) in install.sh for ports Reply-To: Stefan Kuttler Hi Mark, On Tue, Apr 06, 2010 at 09:35:15PM -0500, Mark Linimon wrote: > > remove cat(1) from install.sh > er, what does this apply to exactly? Source: ftp://ftp.freebsd.org/pub/FreeBSD/releases/i386/8.0-RELEASE/ports/install.sh Destination: maybe misc or ports ----- End forwarded message ----- State-Changed-From-To: open->patched State-Changed-By: brian State-Changed-When: Sat Jun 19 09:33:20 UTC 2010 State-Changed-Why: Applied to head (r209332). I'll MFC in a week. http://www.freebsd.org/cgi/query-pr.cgi?pr=145447 From: dfilter@FreeBSD.ORG (dfilter service) To: bug-followup@FreeBSD.org Cc: Subject: Re: misc/145447: commit references a PR Date: Sat, 19 Jun 2010 09:33:24 +0000 (UTC) Author: brian Date: Sat Jun 19 09:33:11 2010 New Revision: 209332 URL: http://svn.freebsd.org/changeset/base/209332 Log: Remove an unnecessary cat. PR: 145447 Submitted by: u at netbeisser dot de MFC after: 1 week Modified: head/release/scripts/ports-install.sh Modified: head/release/scripts/ports-install.sh ============================================================================== --- head/release/scripts/ports-install.sh Sat Jun 19 09:21:34 2010 (r209331) +++ head/release/scripts/ports-install.sh Sat Jun 19 09:33:11 2010 (r209332) @@ -8,5 +8,5 @@ if [ "`id -u`" != "0" ]; then exit 1 fi echo "Extracting ports tarball into ${DESTDIR}/usr" -cat ports.tgz | tar --unlink -xpzf - -C ${DESTDIR}/usr +tar --unlink -xpzf ports.tgz -C ${DESTDIR}/usr exit 0 _______________________________________________ svn-src-all@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/svn-src-all To unsubscribe, send any mail to "svn-src-all-unsubscribe@freebsd.org" State-Changed-From-To: patched->closed State-Changed-By: brian State-Changed-When: Mon Jun 28 07:03:32 UTC 2010 State-Changed-Why: Merged to stable/8, r209562. http://www.freebsd.org/cgi/query-pr.cgi?pr=145447 From: dfilter@FreeBSD.ORG (dfilter service) To: bug-followup@FreeBSD.org Cc: Subject: Re: misc/145447: commit references a PR Date: Mon, 28 Jun 2010 07:03:36 +0000 (UTC) Author: brian Date: Mon Jun 28 07:03:18 2010 New Revision: 209562 URL: http://svn.freebsd.org/changeset/base/209562 Log: MFC r209332: Shoot a stray cat! PR: 145447 Submitted by: u at netbeisser dot de Modified: stable/8/release/scripts/ports-install.sh Directory Properties: stable/8/release/ (props changed) stable/8/release/doc/en_US.ISO8859-1/hardware/ (props changed) stable/8/release/picobsd/ (props changed) stable/8/release/picobsd/floppy.tree/sbin/ (props changed) stable/8/release/picobsd/floppy.tree/sbin/dhclient-script (props changed) stable/8/release/picobsd/qemu/ (props changed) Modified: stable/8/release/scripts/ports-install.sh ============================================================================== --- stable/8/release/scripts/ports-install.sh Mon Jun 28 06:59:57 2010 (r209561) +++ stable/8/release/scripts/ports-install.sh Mon Jun 28 07:03:18 2010 (r209562) @@ -8,5 +8,5 @@ if [ "`id -u`" != "0" ]; then exit 1 fi echo "Extracting ports tarball into ${DESTDIR}/usr" -cat ports.tgz | tar --unlink -xpzf - -C ${DESTDIR}/usr +tar --unlink -xpzf ports.tgz -C ${DESTDIR}/usr exit 0 _______________________________________________ svn-src-all@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/svn-src-all To unsubscribe, send any mail to "svn-src-all-unsubscribe@freebsd.org" >Unformatted: