From nobody@FreeBSD.org Tue Dec 13 13:26:21 2011 Return-Path: Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 8A5151065670 for ; Tue, 13 Dec 2011 13:26:21 +0000 (UTC) (envelope-from nobody@FreeBSD.org) Received: from red.freebsd.org (red.freebsd.org [IPv6:2001:4f8:fff6::22]) by mx1.freebsd.org (Postfix) with ESMTP id 797688FC15 for ; Tue, 13 Dec 2011 13:26:21 +0000 (UTC) Received: from red.freebsd.org (localhost [127.0.0.1]) by red.freebsd.org (8.14.4/8.14.4) with ESMTP id pBDDQKfa085466 for ; Tue, 13 Dec 2011 13:26:20 GMT (envelope-from nobody@red.freebsd.org) Received: (from nobody@localhost) by red.freebsd.org (8.14.4/8.14.4/Submit) id pBDDQKgu085465; Tue, 13 Dec 2011 13:26:20 GMT (envelope-from nobody) Message-Id: <201112131326.pBDDQKgu085465@red.freebsd.org> Date: Tue, 13 Dec 2011 13:26:20 GMT From: Eugen Konkov To: freebsd-gnats-submit@FreeBSD.org Subject: kernel panic if set /boot/loader.conf vfs.root.mountfrom=asdfasdf X-Send-Pr-Version: www-3.1 X-GNATS-Notify: >Number: 163245 >Category: kern >Synopsis: kernel panic if set /boot/loader.conf vfs.root.mountfrom=asdfasdf >Confidential: no >Severity: non-critical >Priority: low >Responsible: marcel >State: open >Quarter: >Keywords: >Date-Required: >Class: sw-bug >Submitter-Id: current-users >Arrival-Date: Tue Dec 13 13:30:09 UTC 2011 >Closed-Date: >Last-Modified: Mon Dec 19 08:05:59 UTC 2011 >Originator: Eugen Konkov >Release: 10.0-CURRENT >Organization: ISP FreeLine >Environment: FreeBSD meta-up 10.0-CURRENT FreeBSD 10.0-CURRENT #0: Sun Dec 11 22:17:57 UTC 2011 :/usr/obj/usr/src/sys/KES_KERN_v10 i386 >Description: when setting this value server says that panic and will reboot after 15 sec instead of allow user to enter correct values as in case right splelling: vfs.root.mountfrom=ufs:/dev/ad100s1a >How-To-Repeat: echo "vfs.root.mountfrom=asdfasdf" >> /boot/loader.conf reboot >Fix: >Release-Note: >Audit-Trail: From: "Andrey V. Elsukov" To: Eugen Konkov Cc: freebsd-gnats-submit@FreeBSD.org, Marcel Moolenaar Subject: Re: misc/163245: kernel panic if set /boot/loader.conf vfs.root.mountfrom=asdfasdf Date: Wed, 14 Dec 2011 13:37:49 +0400 On 13.12.2011 17:26, Eugen Konkov wrote: >> Description: > when setting this value server says that > panic and will reboot after 15 sec > instead of allow user to enter correct values as in case right splelling: > > vfs.root.mountfrom=ufs:/dev/ad100s1a > > >> How-To-Repeat: > echo "vfs.root.mountfrom=asdfasdf" >> /boot/loader.conf > reboot >> Fix: Hi, Eugen. Can you try this patch? http://people.freebsd.org/~ae/mountroot.diff Also, Marcel, what you think about it? -- WBR, Andrey V. Elsukov Responsible-Changed-From-To: freebsd-bugs->marcel Responsible-Changed-By: avg Responsible-Changed-When: Wed Dec 14 09:53:37 UTC 2011 Responsible-Changed-Why: Marcel, can you please take a look? http://www.freebsd.org/cgi/query-pr.cgi?pr=163245 From: Andriy Gapon To: bug-followup@FreeBSD.org, kes-kes@yandex.ru Cc: Subject: Re: misc/163245: kernel panic if set /boot/loader.conf vfs.root.mountfrom=asdfasdf Date: Wed, 14 Dec 2011 11:53:17 +0200 Not sure if teh current behavior is intentional, but I would really prefer it in case I tweak a system remotely and vfs.root.mountfrom is specified in nextboot.conf. If I am at the console then there are multiple ways to recover from the situation. -- Andriy Gapon From: =?windows-1251?B?yu7t/Oru4iDF4uPl7ejp?= To: bug-followup@FreeBSD.org, kes-kes@yandex.ru Cc: Subject: Re: misc/163245: kernel panic if set /boot/loader.conf vfs.root.mountfrom=asdfasdf Date: Fri, 16 Dec 2011 20:34:25 +0200 I am sorry, but on 10-CURRENT I can not test this patch now ( But on 9.0-CURRENT FreeBSD 9.0-CURRENT #1: Thu Oct 28 01:00:21 Hmm... Looks like a unified diff to me... The text leading up to this was: -------------------------- |--- head/sys/kern/vfs_mountroot.c (revision 228491) |+++ head/sys/kern/vfs_mountroot.c (working copy) -------------------------- Patching file vfs_mountroot.c using Plan A... Hunk #1 failed at 500. Hunk #2 failed at 560. Hunk #3 failed at 601. Hunk #4 failed at 679. Hunk #5 failed at 786. Hunk #6 failed at 831. 6 out of 6 hunks failed--saving rejects to vfs_mountroot.c.rej >Unformatted: