From patc@hyacinth.ucc.su.oz.au Wed Apr 10 08:05:45 1996 Received: from hyacinth.ucc.su.oz.au (ts-a12-1-52.ucc.su.OZ.AU [129.78.208.53]) by freefall.freebsd.org (8.7.3/8.7.3) with ESMTP id IAA13350 for ; Wed, 10 Apr 1996 08:05:35 -0700 (PDT) Received: (from patc@localhost) by hyacinth.ucc.su.oz.au (8.7.5/8.7.3) id BAA00672; Thu, 11 Apr 1996 01:07:56 +1000 (EST) Message-Id: <199604101507.BAA00672@hyacinth.ucc.su.oz.au> Date: Thu, 11 Apr 1996 01:07:56 +1000 (EST) From: Pat Caldon Reply-To: patc@felix.antiquity.arts.su.edu.au To: FreeBSD-gnats-submit@freebsd.org Subject: sys/i386/isa/matcd/matcd.c will not compile X-Send-Pr-Version: 3.2 >Number: 1129 >Category: kern >Synopsis: matcd.c (Panasonic cdrom driver) will not compile >Confidential: no >Severity: serious >Priority: low >Responsible: uhclem >State: closed >Quarter: >Keywords: >Date-Required: >Class: sw-bug >Submitter-Id: current-users >Arrival-Date: Wed Apr 10 08:10:02 PDT 1996 >Closed-Date: Tue May 7 00:35:52 PDT 1996 >Last-Modified: Tue May 7 00:36:06 PDT 1996 >Originator: Pat Caldon >Release: FreeBSD 2.2-CURRENT i386 >Organization: little or none >Environment: Panasonic CD-ROM on a Soundblaser card; -current as of April 7. >Description: The driver will not compile and spews out hudreds of error messages: ../../i386/isa/matcd/matcd.c:504: `isa_generic_externalize' undeclared here (not in a function) ../../i386/isa/matcd/matcd.c:504: initializer element for `kdc_matcd.kdc_externalize' is not constant ../../i386/isa/matcd/matcd.c:504: `ISA_EXTERNALLEN' undeclared here (not in a function) ../../i386/isa/matcd/matcd.c:504: initializer element for `kdc_matcd.kdc_datalen' is not constant ../../i386/isa/matcd/matcd.c:505: `kdc_isa0' undeclared here (not in a function) ../../i386/isa/matcd/matcd.c:505: initializer element for `kdc_matcd.kdc_parent' is not constant ../../i386/isa/matcd/matcd.c:549: warning: `struct isa_device' declared inside parameter list ../../i386/isa/matcd/matcd.c:549: warning: its scope is only this definition or declaration, [ and pages more ] >How-To-Repeat: # config GENERIC # cd ../../compile/GENERIC # make matcd.o >Fix: The following patch seems to work: *** matcd.c.orig Thu Apr 11 00:38:29 1996 --- matcd.c Thu Apr 11 00:40:33 1996 *************** *** 364,376 **** #include /*<16>*/ #include #include #ifdef DEVFS #include #endif /*DEVFS*/ - #else /*FREE2*/ - #include /*<16>*/ - #include /*<16>*/ - #endif /*FREE2*/ /*--------------------------------------------------------------------------- Defines and structures --- 364,374 ---- #include /*<16>*/ #include #include + #include /*<16>*/ + #include /*<16>*/ #ifdef DEVFS #include #endif /*DEVFS*/ /*--------------------------------------------------------------------------- Defines and structures >Release-Note: >Audit-Trail: Responsible-Changed-From-To: freebsd-bugs->uhclem Responsible-Changed-By: scrappy Responsible-Changed-When: Fri Apr 12 20:56:25 PDT 1996 Responsible-Changed-Why: this is Frank's baby State-Changed-From-To: open->closed State-Changed-By: phk State-Changed-When: Tue May 7 00:35:52 PDT 1996 State-Changed-Why: compiles fine now. >Unformatted: