From sbauer@rock.sdsmt.edu Mon Jul 14 20:32:56 1997 Received: from krypton.hpc.sdsmt.edu (uurock@krypton.hpc.sdsmt.edu [151.159.81.5]) by hub.freebsd.org (8.8.5/8.8.5) with ESMTP id UAA01927 for ; Mon, 14 Jul 1997 20:32:55 -0700 (PDT) Received: (from uurock@localhost) by krypton.hpc.sdsmt.edu (8.8.6/8.8.6) id VAA16560 for FreeBSD-gnats-submit@freebsd.org; Mon, 14 Jul 1997 21:32:49 -0600 Received: (from sbauer@localhost) by rock.sdsmt.edu (8.8.5/8.8.5) id VAA00374; Mon, 14 Jul 1997 21:31:58 -0600 (MDT) Message-Id: <199707150331.VAA00374@rock.sdsmt.edu> Date: Mon, 14 Jul 1997 21:31:58 -0600 (MDT) From: sbauer@rock.sdsmt.edu Reply-To: sbauer@rock.sdsmt.edu To: FreeBSD-gnats-submit@freebsd.org Subject: 82371SB Chipset being configured incorrectly. X-Send-Pr-Version: 3.2 >Number: 4092 >Category: i386 >Synopsis: 82371SB Chipset being configured incorrectly. >Confidential: no >Severity: serious >Priority: medium >Responsible: freebsd-bugs >State: closed >Quarter: >Keywords: >Date-Required: >Class: sw-bug >Submitter-Id: current-users >Arrival-Date: Mon Jul 14 20:40:00 PDT 1997 >Closed-Date: Fri Jul 18 12:48:41 PDT 1997 >Last-Modified: Fri Jul 18 12:50:40 PDT 1997 >Originator: Steve Bauer >Release: FreeBSD 2.2-STABLE i386 >Organization: South Dakota School of Mines and Technology >Environment: FreeBSD 2.2-Stable with ctm of 345 applied. >Description: The 82371SB Chipest seems to be configured incorrectly in the file pcisupport.c The reason for this conclusion is the fact that the 82371FB (Triton I) is compatible with the 82371SB (Triton II) chipset. Yet in pcisupport.c when the 82371FB (Function 0) (0x12308086) is configured the same information is sent to the 82371SB (Function 1) (0x70108086) which is the ide controller. I do not believe this is correct since the chipsets are basically register compatible. The changes that I have made are the following: Change line 722 from 0x70108086 to 0x70008086 -- This way it will be configurting Function 0 of the 82371SB chipset. Also, I added case 70108086: at line 726 so that the function 1 (IDE interface) would be configured the same way as it is in the 82371FB chipset. >How-To-Repeat: I am not sure if this really caused much of a problem or not. It appears to have fixed some random lockups that I have been having with my machine. >Fix: Below is a patch that implements that fixes that I described above. *** pcisupport.c.orig Sun Jul 13 00:18:32 1997 --- pcisupport.c Sun Jul 13 00:19:04 1997 *************** *** 719,728 **** case 0x70308086: writeconfig (config_id, conf82437vx); break; ! case 0x70108086: case 0x122e8086: writeconfig (config_id, conf82371fb); break; case 0x12308086: writeconfig (config_id, conf82371fb2); break; --- 719,729 ---- case 0x70308086: writeconfig (config_id, conf82437vx); break; ! case 0x70008086: case 0x122e8086: writeconfig (config_id, conf82371fb); break; + case 0x70108086: case 0x12308086: writeconfig (config_id, conf82371fb2); break; >Release-Note: >Audit-Trail: From: Stefan Esser To: sbauer@rock.sdsmt.edu Cc: FreeBSD-gnats-submit@freebsd.org, Stefan Esser Subject: Re: i386/4092: 82371SB Chipset being configured incorrectly. Date: Wed, 16 Jul 1997 21:49:38 +0200 On Jul 14, sbauer@rock.sdsmt.edu wrote: > The 82371SB Chipest seems to be configured incorrectly in the > file pcisupport.c The reason for this conclusion is the fact that the > 82371FB (Triton I) is compatible with the 82371SB (Triton II) chipset. > Yet in pcisupport.c when the 82371FB (Function 0) (0x12308086) is configured > the same information is sent to the 82371SB (Function 1) (0x70108086) which > is the ide controller. I do not believe this is correct since the chipsets > are basically register compatible. The changes that I have made are the > following: > Change line 722 from 0x70108086 to 0x70008086 -- This way it will > be configurting Function 0 of the 82371SB chipset. Also, I added > case 70108086: at line 726 so that the function 1 (IDE interface) would > be configured the same way as it is in the 82371FB chipset. Thanks for sending the patch. I think you are right and I'm going to commit your patch on my next login to the FreeBSD repository server ... Regards, STefan State-Changed-From-To: open->closed State-Changed-By: se State-Changed-When: Fri Jul 18 12:48:41 PDT 1997 State-Changed-Why: Suggested patch was applied to -current (1.48) and 2.2 (1.40.2.4) versions of pcisupport.c. >Unformatted: