From larson@eng.paix.net Tue Nov 12 17:19:52 2002 Return-Path: Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id D198537B401 for ; Tue, 12 Nov 2002 17:19:52 -0800 (PST) Received: from ground0.paix.net (ground0.paix.net [128.177.247.242]) by mx1.FreeBSD.org (Postfix) with ESMTP id 7FF6E43E3B for ; Tue, 12 Nov 2002 17:19:52 -0800 (PST) (envelope-from larson@eng.paix.net) Received: (from larson@localhost) by ground0.paix.net (8.9.3/8.9.1) id RAA35594; Tue, 12 Nov 2002 17:19:52 -0800 (PST) env-from (larson@eng.paix.net) Message-Id: <200211130119.RAA35594@ground0.paix.net> Date: Tue, 12 Nov 2002 17:19:52 -0800 (PST) From: Alan Larson Reply-To: larson@eng.paix.net To: FreeBSD-gnats-submit@freebsd.org Subject: Sysinstall installs things it should not install, XF86 in my case. X-Send-Pr-Version: 3.2 >Number: 45254 >Category: bin >Synopsis: [sysinstall] [patch] sysinstall installs things it should not install, XF86 in my case. >Confidential: no >Severity: non-critical >Priority: medium >Responsible: freebsd-bugs >State: closed >Quarter: >Keywords: >Date-Required: >Class: sw-bug >Submitter-Id: current-users >Arrival-Date: Tue Nov 12 17:20:04 PST 2002 >Closed-Date: Tue Dec 16 17:13:20 UTC 2008 >Last-Modified: Tue Dec 16 17:13:20 UTC 2008 >Originator: Alan Larson >Release: FreeBSD 4.6.2-RELEASE i386 >Organization: PAIX.net >Environment: 4.6.2 install CD >Description: When you want to install almost everything, an obvious thing to try is to click on "All", and then select the things you DON'T want to turn them off. Doing this with XF86 doesn't work, since distSetEverything() turns on XF86Dists = DIST_XF86_ALL; XF86ServerDists = DIST_XF86_SERVER_ALL; XF86FontDists = DIST_XF86_FONTS_ALL; but unsetting XF86 doesn't turn them off. >How-To-Repeat: Do system install, or Upgrade, select "All", then go down into custom and unselect "XFree86 Distribution". Watching the install, or looking at the results, you see a bunch of it still got installed. >Fix: For now, as a work-around, note that the software is demented. Later, someone should clear all the XF86 stuff there when it is turned off. While there, shortening the code needed to do an exclusive-OR in the routine dmenuSetFlag() might inspire more confidence. int dmenuSetFlag(dialogMenuItem *tmp) { if (*((unsigned int *)tmp->data) & tmp->aux) *((unsigned int *)tmp->data) &= ~tmp->aux; else *((unsigned int *)tmp->data) |= tmp->aux; return DITEM_SUCCESS; } int dmenuSetFlag(dialogMenuItem *tmp) { *((unsigned int *)tmp->data) ^= tmp->aux; /* toggle bit on/off */ return DITEM_SUCCESS; } >Release-Note: >Audit-Trail: Responsible-Changed-From-To: freebsd-bugs->qa Responsible-Changed-By: matusita Responsible-Changed-When: Wed Nov 13 03:19:28 PST 2002 Responsible-Changed-Why: Sysinstall(8) issue. http://www.freebsd.org/cgi/query-pr.cgi?pr=45254 State-Changed-From-To: open->closed State-Changed-By: kensmith State-Changed-When: Tue Dec 16 17:12:05 UTC 2008 State-Changed-Why: Handling (now...) Xorg as a distribution was dropped completely in r186152. http://www.freebsd.org/cgi/query-pr.cgi?pr=45254 >Unformatted: