From matusita@jp.freebsd.org Mon Jul 31 04:12:37 2000 Return-Path: Received: from castle.jp.freebsd.org (castle.jp.FreeBSD.org [210.226.20.15]) by hub.freebsd.org (Postfix) with ESMTP id 6FA4037BC17 for ; Mon, 31 Jul 2000 04:12:36 -0700 (PDT) (envelope-from matusita@jp.freebsd.org) Received: from localhost (localhost [127.0.0.1]) by castle.jp.freebsd.org (8.9.3+3.2W/8.7.3) with ESMTP id UAA92577 for ; Mon, 31 Jul 2000 20:12:35 +0900 (JST) (envelope-from matusita@jp.FreeBSD.org) Message-Id: <20000731201222N.matusita@jp.FreeBSD.org> Date: Mon, 31 Jul 2000 20:12:22 +0900 From: Makoto MATSUSHITA To: FreeBSD-gnats-submit@freebsd.org Subject: src/release/Makefile: broken CHECKSUM.MD5 >Number: 20311 >Category: bin >Synopsis: src/release/Makefile: broken CHECKSUM.MD5 >Confidential: no >Severity: non-critical >Priority: low >Responsible: markm >State: closed >Quarter: >Keywords: >Date-Required: >Class: change-request >Submitter-Id: current-users >Arrival-Date: Mon Jul 31 04:20:00 PDT 2000 >Closed-Date: Wed Jan 30 07:22:49 PST 2002 >Last-Modified: Wed Jan 30 07:23:53 PST 2002 >Originator: Makoto MATSUSHITA >Release: FreeBSD 5.0-CURRENT i386 >Organization: Japan FreeBSD Users' Group >Environment: Recent 4-stable/-current >Description: target 'release.7' of src/release/Makefile does make a source distributions such as src/sbase.* etc. This target does - Create tarball for earch src/* directory - Do additional tarball listed in EXTRA_SRC - Move crypto-related source to ../crypto ... but all MD5 signature of src/scrypto.* (and crypto-related source file chunks) are still in src/CHECKSUM.MD5. Moreover, crypto/CHECKSUM.MD5 have only *krb5* checksums. >How-To-Repeat: Do 'make buildworld' and see the results. >Fix: CHECKSUM.MD5 should be created *after* all distributions are placed as it is. An example to fix: - stop creating CHECKSUM.MD5 in 'doTARBALL' target - creating CHECKSUM.MD5 in the end of 'release.7' >Release-Note: >Audit-Trail: Responsible-Changed-From-To: freebsd-bugs->markm Responsible-Changed-By: sheldonh Responsible-Changed-When: Mon Jul 31 05:31:16 PDT 2000 Responsible-Changed-Why: Mark, this is the problem that DES complained about recently. http://www.freebsd.org/cgi/query-pr.cgi?pr=20311 From: Makoto MATSUSHITA To: freebsd-gnats-submit@FreeBSD.org Cc: stable@FreeBSD.org Subject: Re: bin/20311: src/release/Makefile: broken CHECKSUM.MD5 Date: Wed, 27 Sep 2000 13:30:44 +0900 Here is a status of this PR. * Assigned to a person. No respondings yet. * CHECKSUM.MD5 is still broken. It also affected to 4.1.1-RELEASE (if you doubt, check 4.1.1-RELEASE/crypto/CHECKSUM.MD5). -- - Makoto `MAR' MATSUSHITA From: Makoto MATSUSHITA To: freebsd-gnats-submit@FreeBSD.org Cc: stable@freebsd.org, current@freebsd.org Subject: Re: bin/20311: src/release/Makefile: broken CHECKSUM.MD5 Date: Tue, 05 Dec 2000 14:58:07 +0900 (forward to stable/current also, to open this problem widely) matusita> * CHECKSUM.MD5 is still broken. It also affected to 4.1.1-RELEASE I cannot believe that this problem is still there, and CHECKSUM.MD5s of 4.2-RELEASE/{src,crypto} are also broken. However, it's easy to fix just like this (CAUTION: I don't test with this): Index: Makefile =================================================================== RCS file: /lab/FreeBSD/FreeBSD.cvs/src/release/Makefile,v retrieving revision 1.586 diff -c -r1.586 Makefile *** Makefile 2000/11/21 04:37:30 1.586 --- Makefile 2000/12/05 05:43:41 *************** *** 503,509 **** if [ -f ssecure.aa ] ; then mv ssecure.* ../crypto ; fi && \ if [ -f scrypto.aa ] ; then mv scrypto.* ../crypto ; fi && \ if [ -f skrb4.aa ] ; then mv skrb4.* ../crypto ; fi && \ ! if [ -f skrb5.aa ] ; then mv skrb5.* ../crypto ; fi ; ) ; fi @echo "src distribution is finished." .endif touch release.7 --- 503,512 ---- if [ -f ssecure.aa ] ; then mv ssecure.* ../crypto ; fi && \ if [ -f scrypto.aa ] ; then mv scrypto.* ../crypto ; fi && \ if [ -f skrb4.aa ] ; then mv skrb4.* ../crypto ; fi && \ ! if [ -f skrb5.aa ] ; then mv skrb5.* ../crypto ; fi ; \ ! cd ${RD}/dists/crypto; rm -f CHECKSUM.MD5; \ ! md5 * > CHECKSUM.MD5 ) ; fi ! (cd ${RD}/dists/src; rm -f CHECKSUM.MD5; md5 * > CHECKSUM.MD5) @echo "src distribution is finished." .endif touch release.7 But if creating CHECKSUM.MD5 files are already totally broken feature, we can simply remove all CHECKSUM.MD5 files. -- - Makoto `MAR' MATSUSHITA State-Changed-From-To: open->closed State-Changed-By: markm State-Changed-When: Wed Jan 30 07:22:49 PST 2002 State-Changed-Why: Originator says problem is fixed satisfactorily. http://www.FreeBSD.org/cgi/query-pr.cgi?pr=20311 >Unformatted: