From jc@irbs.com Sun May 26 16:10:29 1996 Received: from irbs.irbs.com ([199.182.75.129]) by freefall.freebsd.org (8.7.5/8.7.3) with ESMTP id QAA04934 for ; Sun, 26 May 1996 16:10:27 -0700 (PDT) Received: (from jc@localhost) by irbs.irbs.com (8.7.5/8.6.6) id TAA13704; Sun, 26 May 1996 19:09:55 -0400 (EDT) Message-Id: <199605262309.TAA13704@irbs.irbs.com> Date: Sun, 26 May 1996 19:09:55 -0400 (EDT) From: John Capo Reply-To: jc@irbs.com To: FreeBSD-gnats-submit@freebsd.org Subject: xroach cores with missing arguments X-Send-Pr-Version: 3.2 >Number: 1254 >Category: bin >Synopsis: xroach cores with missing arguments >Confidential: no >Severity: non-critical >Priority: low >Responsible: freebsd-bugs >State: closed >Quarter: >Keywords: >Date-Required: >Class: sw-bug >Submitter-Id: current-users >Arrival-Date: Sun May 26 16:20:01 PDT 1996 >Closed-Date: Sun May 26 18:36:38 PDT 1996 >Last-Modified: Sun May 26 18:38:15 PDT 1996 >Originator: John Capo >Release: FreeBSD 2.1-STABLE i386 >Organization: >Environment: >Description: Omit numeric arg with flag that expects one and xroach will core. >How-To-Repeat: xroach -roaches will do it I think. >Fix: *** /usr/stable/src/games/x11/xroach/xroach.c Sat May 4 21:18:41 1996 --- games/x11/xroach/xroach.c Sat May 4 17:50:29 1996 *************** *** 96,114 **** /* Process command line options. */ ! for (ax=1; ax= ac) ! Usage(); ! if (strcmp(arg, "-display") == 0) { ! display_name = av[ax++]; } else if (strcmp(arg, "-rc") == 0) { ! roachColor = av[ax++]; } else if (strcmp(arg, "-speed") == 0) { ! roachSpeed = atof(av[ax++]); } else if (strcmp(arg, "-roaches") == 0) { ! maxRoaches = strtol(av[ax++], (char **)NULL, 0); } else { Usage(); >Release-Note: >Audit-Trail: From: asami@cs.berkeley.edu (Satoshi Asami) To: FreeBSD-gnats-submit@freefall.freebsd.org, jc@irbs.com Cc: Subject: Re: bin/1254: xroach cores with missing arguments Date: Sun, 26 May 1996 18:08:38 -0700 (PDT) * Omit numeric arg with flag that expects one and xroach will core. * *** /usr/stable/src/games/x11/xroach/xroach.c Sat May 4 21:18:41 1996 * --- games/x11/xroach/xroach.c Sat May 4 17:50:29 1996 Thanks, I took the patch and added it as patch-ab of ports/games/xroach. I'm not sure what to do about the xroach in -stable though -- xroach (and xneko) has been added to the ports tree after the 2.1 release, which means it's technically unsupported for the 2.1-* branch.... Satoshi State-Changed-From-To: open->closed State-Changed-By: jkh State-Changed-When: Sun May 26 18:36:38 PDT 1996 State-Changed-Why: xroach was still lurking in -stable (long since nuked from -current), it's now gone. >Unformatted: